Skip to content

Commit ccbe144

Browse files
vitstnvitstn
authored
init (#1375)
1 parent 5959806 commit ccbe144

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+37
-100
lines changed

‎ydb/library/yql/minikql/codegen/codegen.cpp

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
#include "codegen.h"
2+
Y_PRAGMA_DIAGNOSTIC_PUSH
3+
Y_PRAGMA("GCC diagnostic ignored \"-Wbitwise-instead-of-logical\"")
24
#include "codegen_llvm_deps.h" // Y_IGNORE
5+
Y_PRAGMA_DIAGNOSTIC_POP
36
#include <contrib/libs/re2/re2/re2.h>
47

58
#include <util/generic/maybe.h>
@@ -567,9 +570,7 @@ class TCodegen : public ICodegen, private llvm::JITEventListener {
567570
std::unique_ptr<void, void(*)(void*)> delDis(dis, LLVMDisasmDispose);
568571
LLVMSetDisasmOptions(dis, LLVMDisassembler_Option_AsmPrinterVariant);
569572
char outline[1024];
570-
int pos;
571-
572-
pos = 0;
573+
size_t pos = 0;
573574
while (pos < size) {
574575
size_t l = LLVMDisasmInstruction(dis, (uint8_t*)buf + pos, size - pos, 0, outline, sizeof(outline));
575576
if (!l) {
@@ -719,7 +720,9 @@ class TCodegen : public ICodegen, private llvm::JITEventListener {
719720
std::string Diagnostic_;
720721
std::string Triple_;
721722
llvm::Module* Module_;
723+
#ifdef __linux__
722724
llvm::JITEventListener* PerfListener_ = nullptr;
725+
#endif
723726
std::unique_ptr<llvm::ExecutionEngine> Engine_;
724727
std::vector<std::pair<llvm::object::SectionRef, ui64>> CodeSections_;
725728
ui64 TotalObjectSize = 0;

‎ydb/library/yql/minikql/codegen/codegen_ut.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ Y_UNIT_TEST_SUITE(TCodegenTests) {
265265
Y_UNIT_TEST(BadFib) {
266266
auto codegen = ICodegen::Make(ETarget::Native);
267267
auto func = CreateBadFibFunction(codegen->GetModule(), codegen->GetContext());
268+
Y_UNUSED(func);
268269
UNIT_ASSERT_EXCEPTION(codegen->Verify(), yexception);
269270
}
270271

@@ -298,6 +299,7 @@ Y_UNIT_TEST_SUITE(TCodegenTests) {
298299
Y_UNIT_TEST(LinkWithGeneratedFunction) {
299300
auto codegen = ICodegen::Make(ETarget::Native);
300301
auto mulFunc = CreateMulFunction(codegen->GetModule(), codegen->GetContext());
302+
Y_UNUSED(mulFunc);
301303
auto bitcode = NResource::Find("/llvm_bc/Funcs");
302304
codegen->LoadBitCode(bitcode, "Funcs");
303305
auto func = codegen->GetModule().getFunction("sum_sqr");

‎ydb/library/yql/minikql/codegen/ut/ya.make.inc

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
OWNER(g:yql)
22

3-
NO_COMPILER_WARNINGS()
4-
53
ADDINCL(
64
${ARCADIA_BUILD_ROOT}/${MODDIR}
75
)

‎ydb/library/yql/minikql/codegen/ya.make.inc

-2
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ COPY_FILE(
4747
codegen_llvm_deps.h
4848
)
4949

50-
NO_COMPILER_WARNINGS()
51-
5250
IF (NOT WINDOWS)
5351
PEERDIR(
5452
contrib/libs/cxxsupp/builtins

‎ydb/library/yql/minikql/comp_nodes/llvm/ut/ya.make

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
UNITTEST()
22

3-
NO_COMPILER_WARNINGS()
4-
53
PEERDIR(
64
ydb/library/yql/minikql/codegen/llvm
75
ydb/library/yql/minikql/comp_nodes/llvm
@@ -16,4 +14,4 @@ PEERDIR(
1614

1715
INCLUDE(../../ut/ya.make.inc)
1816

19-
END()
17+
END()

‎ydb/library/yql/minikql/comp_nodes/llvm/ya.make

-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ OWNER(
55
g:yql_ydb_core
66
)
77

8-
NO_COMPILER_WARNINGS()
9-
108
PEERDIR(
119
ydb/library/yql/minikql/codegen/llvm
1210
ydb/library/yql/minikql/invoke_builtins/llvm

‎ydb/library/yql/minikql/comp_nodes/llvm14/ut/ya.make

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
UNITTEST()
22

3-
NO_COMPILER_WARNINGS()
4-
53
PEERDIR(
64
ydb/library/yql/minikql/codegen/llvm14
75
ydb/library/yql/minikql/comp_nodes/llvm14
@@ -16,4 +14,4 @@ PEERDIR(
1614

1715
INCLUDE(../../ut/ya.make.inc)
1816

19-
END()
17+
END()

‎ydb/library/yql/minikql/comp_nodes/llvm14/ya.make

-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ OWNER(
55
g:yql_ydb_core
66
)
77

8-
NO_COMPILER_WARNINGS()
9-
108
PEERDIR(
119
ydb/library/yql/minikql/codegen/llvm14
1210
ydb/library/yql/minikql/invoke_builtins/llvm14

‎ydb/library/yql/minikql/comp_nodes/mkql_block_agg.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,6 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TBlockCombineAllWrap
509509
auto& context = ctx.Codegen.GetContext();
510510

511511
const auto valueType = Type::getInt128Ty(context);
512-
const auto ptrValueType = PointerType::getUnqual(valueType);
513512
const auto statusType = Type::getInt32Ty(context);
514513
const auto indexType = Type::getInt64Ty(context);
515514
const auto flagType = Type::getInt1Ty(context);
@@ -609,6 +608,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TBlockCombineAllWrap
609608
ICodegeneratorInlineWideNode::TGettersList getters(AggsParams_.size());
610609
for (size_t idx = 0U; idx < getters.size(); ++idx) {
611610
getters[idx] = [idx, getType, getPtr, indexType, statePtrType, stateOnStack](const TCodegenContext& ctx, BasicBlock*& block) {
611+
Y_UNUSED(ctx);
612612
const auto stateArg = new LoadInst(statePtrType, stateOnStack, "state", block);
613613
return CallInst::Create(getType, getPtr, {stateArg, ConstantInt::get(indexType, idx)}, "get", block);
614614
};
@@ -921,7 +921,6 @@ class THashedWrapperBase : public TStatefulWideFlowCodegeneratorNode<TDerived> {
921921
auto& context = ctx.Codegen.GetContext();
922922

923923
const auto valueType = Type::getInt128Ty(context);
924-
const auto ptrValueType = PointerType::getUnqual(valueType);
925924
const auto statusType = Type::getInt32Ty(context);
926925
const auto indexType = Type::getInt64Ty(context);
927926
const auto flagType = Type::getInt1Ty(context);

‎ydb/library/yql/minikql/comp_nodes/mkql_block_compress.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,6 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TCompressBlocks>;
308308
const auto width = Types_.size() + 1U;
309309

310310
const auto valueType = Type::getInt128Ty(context);
311-
const auto ptrValueType = PointerType::getUnqual(valueType);
312311
const auto statusType = Type::getInt32Ty(context);
313312
const auto indexType = Type::getInt64Ty(context);
314313
const auto arrayType = ArrayType::get(valueType, width);
@@ -479,7 +478,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TCompressBlocks>;
479478

480479
ICodegeneratorInlineWideNode::TGettersList getters(width);
481480
for (size_t idx = 0U; idx < getters.size(); ++idx) {
482-
getters[idx] = [idx, width, getType, getPtr, heightPtr, indexType, valueType, statePtrType, stateOnStack, getter = getres.second[idx < BitmapIndex_ ? idx : idx + 1U]](const TCodegenContext& ctx, BasicBlock*& block) {
481+
getters[idx] = [idx, getType, getPtr, heightPtr, indexType, valueType, statePtrType, stateOnStack, getter = getres.second[idx < BitmapIndex_ ? idx : idx + 1U]](const TCodegenContext& ctx, BasicBlock*& block) {
483482
auto& context = ctx.Codegen.GetContext();
484483
const auto pass = BasicBlock::Create(context, "pass", ctx.Func);
485484
const auto call = BasicBlock::Create(context, "call", ctx.Func);

‎ydb/library/yql/minikql/comp_nodes/mkql_block_top.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ using TChunkedArrayIndex = std::vector<IArrayBuilder::TArrayDataItem>;
8383
const auto width = Columns_.size() + 1U;
8484

8585
const auto valueType = Type::getInt128Ty(context);
86-
const auto ptrValueType = PointerType::getUnqual(valueType);
8786
const auto statusType = Type::getInt32Ty(context);
8887
const auto indexType = Type::getInt64Ty(context);
8988
const auto flagType = Type::getInt1Ty(context);

‎ydb/library/yql/minikql/comp_nodes/mkql_blocks.cpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TWideToBlocksWrapper
114114
auto& context = ctx.Codegen.GetContext();
115115

116116
const auto valueType = Type::getInt128Ty(context);
117-
const auto ptrValueType = PointerType::getUnqual(valueType);
118117
const auto statusType = Type::getInt32Ty(context);
119118
const auto indexType = Type::getInt64Ty(context);
120119

@@ -629,7 +628,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TWideFromBlocksWrapp
629628

630629
ICodegeneratorInlineWideNode::TGettersList getters(width);
631630
for (size_t idx = 0U; idx < getters.size(); ++idx) {
632-
getters[idx] = [idx, width, getType, getPtr, valueType, indexType, arrayType, ptrValuesType, stateType, statePtrType, stateOnStack, getBlocks = getres.second](const TCodegenContext& ctx, BasicBlock*& block) {
631+
getters[idx] = [idx, width, getType, getPtr, indexType, arrayType, ptrValuesType, stateType, statePtrType, stateOnStack, getBlocks = getres.second](const TCodegenContext& ctx, BasicBlock*& block) {
633632
auto& context = ctx.Codegen.GetContext();
634633
const auto init = BasicBlock::Create(context, "init", ctx.Func);
635634
const auto call = BasicBlock::Create(context, "call", ctx.Func);
@@ -979,7 +978,6 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TBlockExpandChunkedW
979978
auto& context = ctx.Codegen.GetContext();
980979

981980
const auto valueType = Type::getInt128Ty(context);
982-
const auto ptrValueType = PointerType::getUnqual(valueType);
983981
const auto statusType = Type::getInt32Ty(context);
984982
const auto indexType = Type::getInt64Ty(context);
985983
const auto arrayType = ArrayType::get(valueType, Width_);

‎ydb/library/yql/minikql/comp_nodes/mkql_chopper.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,6 @@ class TChopperFlowWrapper : public TStatefulFlowCodegeneratorNode<TChopperFlowWr
133133
ctx.Ctx = &*ctx.Func->arg_begin();
134134
ctx.Ctx->addAttr(Attribute::NonNull);
135135

136-
const auto indexType = Type::getInt32Ty(context);
137-
138136
auto block = main;
139137

140138
const auto load = BasicBlock::Create(context, "load", ctx.Func);

‎ydb/library/yql/minikql/comp_nodes/mkql_combine.cpp

-3
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,6 @@ class TCombineCoreFlowWrapper: public std::conditional_t<IsMultiRowState,
256256

257257
const auto valueType = Type::getInt128Ty(context);
258258
const auto ptrValueType = PointerType::getUnqual(valueType);
259-
const auto structPtrType = PointerType::getUnqual(StructType::get(context));
260-
const auto contextType = GetCompContextType(context);
261259
const auto statusType = Type::getInt32Ty(context);
262260

263261
TLLVMFieldsStructureState fieldsStruct(context);
@@ -724,7 +722,6 @@ class TCombineCoreWrapper: public TCustomValueCodegeneratorNode<TCombineCoreWrap
724722

725723
const auto valueType = Type::getInt128Ty(context);
726724
const auto ptrValueType = PointerType::getUnqual(valueType);
727-
const auto structPtrType = PointerType::getUnqual(StructType::get(context));
728725
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(ptrValueType) : static_cast<Type*>(valueType);
729726
const auto contextType = GetCompContextType(context);
730727
const auto statusType = Type::getInt32Ty(context);

‎ydb/library/yql/minikql/comp_nodes/mkql_decimal_mod.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ class TDecimalModWrapper : public TMutableCodegeneratorNode<TDecimalModWrapper<I
5252
BinaryOperator::CreateAnd(left, right, "test", block):
5353
IsLeftOptional ? left : right;
5454

55-
const auto check = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, test, zero, "check", block);
5655
result->addIncoming(zero, block);
5756
BranchInst::Create(done, good, IsEmpty(test, block), block);
5857

‎ydb/library/yql/minikql/comp_nodes/mkql_discard.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ class TDiscardWrapper : public TCustomValueCodegeneratorNode<TDiscardWrapper> {
179179

180180
ctx.Ctx = &*args;
181181
const auto containerArg = &*++args;
182-
const auto valuePtr = &*++args;
183182

184183
const auto main = BasicBlock::Create(context, "main", ctx.Func);
185184
auto block = main;

‎ydb/library/yql/minikql/comp_nodes/mkql_ensure.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ class TEnsureWrapper : public TMutableCodegeneratorNode<TEnsureWrapper> {
3535
#ifndef MKQL_DISABLE_CODEGEN
3636
Value* DoGenerateGetValue(const TCodegenContext& ctx, BasicBlock*& block) const {
3737
auto& context = ctx.Codegen.GetContext();
38-
const auto valueType = Type::getInt128Ty(context);
3938

4039
const auto predicate = GetNodeValue(Predicate, ctx, block);
4140
const auto pass = CastInst::Create(Instruction::Trunc, predicate, Type::getInt1Ty(context), "bool", block);

‎ydb/library/yql/minikql/comp_nodes/mkql_extend.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TExtendWideFlowWrapp
190190
ICodegeneratorInlineWideNode::TGettersList getters(Width_);
191191
for (size_t idx = 0U; idx < getters.size(); ++idx) {
192192
getters[idx] = [idx, valueType, arrayType, arrayPtr, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
193+
Y_UNUSED(ctx);
193194
const auto valuePtr = GetElementPtrInst::CreateInBounds(arrayType, arrayPtr, { ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx)}, "value_ptr", block);
194195
return new LoadInst(valueType, valuePtr, "value", block);
195196
};
@@ -373,10 +374,6 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TOrderedExtendWideFl
373374

374375
TLLVMFieldsStructureState stateFields(context);
375376

376-
const auto stateType = StructType::get(context, stateFields.GetFieldsArray());
377-
const auto statePtrType = PointerType::getUnqual(stateType);
378-
const auto funcType = FunctionType::get(Type::getVoidTy(context), {statePtrType}, false);
379-
380377
const auto main = BasicBlock::Create(context, "main", ctx.Func);
381378
const auto next = BasicBlock::Create(context, "next", ctx.Func);
382379
const auto done = BasicBlock::Create(context, "done", ctx.Func);
@@ -436,6 +433,7 @@ using TBaseComputation = TStatefulWideFlowCodegeneratorNode<TOrderedExtendWideFl
436433
ICodegeneratorInlineWideNode::TGettersList getters(Width_);
437434
for (size_t idx = 0U; idx < getters.size(); ++idx) {
438435
getters[idx] = [idx, valueType, arrayType, arrayPtr, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
436+
Y_UNUSED(ctx);
439437
const auto valuePtr = GetElementPtrInst::CreateInBounds(arrayType, arrayPtr, { ConstantInt::get(indexType, 0), ConstantInt::get(indexType, idx)}, "value_ptr", block);
440438
return new LoadInst(valueType, valuePtr, "value", block);
441439
};

‎ydb/library/yql/minikql/comp_nodes/mkql_flow.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ using TBaseComputation = TWideFlowSourceCodegeneratorNode<TToWideFlowWrapper>;
348348

349349
TGettersList getters(Width);
350350
for (auto i = 0U; i < getters.size(); ++i) {
351-
getters[i] = [idx = TempStateIndex + i, values, valueType, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
351+
getters[i] = [idx = TempStateIndex + i, valueType, indexType](const TCodegenContext& ctx, BasicBlock*& block) {
352352
const auto valuePtr = GetElementPtrInst::CreateInBounds(valueType, ctx.GetMutables(), {ConstantInt::get(indexType, idx)}, (TString("ptr_") += ToString(idx)).c_str(), block);
353353
return new LoadInst(valueType, valuePtr, (TString("val_") += ToString(idx)).c_str(), block);
354354
};

‎ydb/library/yql/minikql/comp_nodes/mkql_fromstring.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,16 @@
99
#include <ydb/library/yql/public/udf/udf_terminator.h>
1010

1111
#ifndef MKQL_DISABLE_CODEGEN
12+
Y_PRAGMA_DIAGNOSTIC_PUSH
13+
Y_PRAGMA("GCC diagnostic ignored \"-Wreturn-type-c-linkage\"")
1214
extern "C" NKikimr::NUdf::TUnboxedValuePod DataFromString(const NKikimr::NUdf::TUnboxedValuePod data, NKikimr::NUdf::EDataSlot slot) {
1315
return NKikimr::NMiniKQL::ValueFromString(slot, data.AsStringRef());
1416
}
1517

1618
extern "C" NYql::NDecimal::TInt128 DecimalFromString(const NKikimr::NUdf::TUnboxedValuePod decimal, ui8 precision, ui8 scale) {
1719
return NYql::NDecimal::FromStringEx(decimal.AsStringRef(), precision, scale);
1820
}
21+
Y_PRAGMA_DIAGNOSTIC_POP
1922
#endif
2023

2124
namespace NKikimr {

‎ydb/library/yql/minikql/comp_nodes/mkql_grace_join.cpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -637,11 +637,6 @@ class TGraceJoinWrapper : public TStatefulWideFlowCodegeneratorNode<TGraceJoinWr
637637

638638
const auto valueType = Type::getInt128Ty(context);
639639
const auto indexType = Type::getInt32Ty(context);
640-
const auto ptrValueType = PointerType::getUnqual(valueType);
641-
const auto structPtrType = PointerType::getUnqual(StructType::get(context));
642-
const auto contextType = GetCompContextType(context);
643-
const auto statusType = Type::getInt32Ty(context);
644-
645640

646641
const auto arrayType = ArrayType::get(valueType, OutputRepresentations.size());
647642
const auto fieldsType = ArrayType::get(PointerType::getUnqual(valueType), OutputRepresentations.size());
@@ -663,6 +658,7 @@ class TGraceJoinWrapper : public TStatefulWideFlowCodegeneratorNode<TGraceJoinWr
663658
initF = InsertValueInst::Create(initF, pointers.back(), {i}, (TString("insert_") += ToString(i)).c_str(), atTop);
664659

665660
getters[i] = [i, values, indexType, arrayType, valueType](const TCodegenContext& ctx, BasicBlock*& block) {
661+
Y_UNUSED(ctx);
666662
const auto pointer = GetElementPtrInst::CreateInBounds(arrayType, values, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, i)}, (TString("ptr_") += ToString(i)).c_str(), block);
667663
return new LoadInst(valueType, pointer, (TString("load_") += ToString(i)).c_str(), block);
668664
};

‎ydb/library/yql/minikql/comp_nodes/mkql_join.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -1162,7 +1162,6 @@ class TWideCommonJoinCoreWrapper : public TStatefulWideFlowCodegeneratorNode<TWi
11621162

11631163
const auto valueType = Type::getInt128Ty(context);
11641164
const auto indexType = Type::getInt32Ty(context);
1165-
const auto structPtrType = PointerType::getUnqual(StructType::get(context));
11661165

11671166
const auto size = LeftOutputColumns.size() + RightOutputColumns.size();
11681167
const auto arrayType = ArrayType::get(valueType, size);
@@ -1185,6 +1184,7 @@ class TWideCommonJoinCoreWrapper : public TStatefulWideFlowCodegeneratorNode<TWi
11851184
initF = InsertValueInst::Create(initF, pointers.back(), {i}, (TString("insert_") += ToString(i)).c_str(), atTop);
11861185

11871186
getters[i] = [i, values, valueType, indexType, arrayType](const TCodegenContext& ctx, BasicBlock*& block) {
1187+
Y_UNUSED(ctx);
11881188
const auto pointer = GetElementPtrInst::CreateInBounds(arrayType, values, {ConstantInt::get(indexType, 0), ConstantInt::get(indexType, i)}, (TString("ptr_") += ToString(i)).c_str(), block);
11891189
return new LoadInst(valueType, pointer, (TString("load_") += ToString(i)).c_str(), block);
11901190
};
@@ -1306,7 +1306,6 @@ class TWideCommonJoinCoreWrapper : public TStatefulWideFlowCodegeneratorNode<TWi
13061306
const auto contextType = GetCompContextType(context);
13071307
const auto resultType = Type::getInt32Ty(context);
13081308
const auto funcType = FunctionType::get(resultType, {PointerType::getUnqual(contextType), PointerType::getUnqual(arrayType)}, false);
1309-
const auto indexType = Type::getInt32Ty(context);
13101309

13111310
TCodegenContext ctx(codegen);
13121311
ctx.Func = cast<Function>(module.getOrInsertFunction(name.c_str(), funcType).getCallee());

‎ydb/library/yql/minikql/comp_nodes/mkql_logical.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ class TNotWrapper : public TDecoratorCodegeneratorNode<TNotWrapper<IsOptional>>
262262

263263
#ifndef MKQL_DISABLE_CODEGEN
264264
Value* DoGenerateGetValue(const TCodegenContext& ctx, Value* arg, BasicBlock*& block) const {
265+
Y_UNUSED(ctx);
265266
const auto xorr = BinaryOperator::CreateXor(arg, ConstantInt::get(arg->getType(), 1), "xor", block);
266267
const auto result = IsOptional ? SelectInst::Create(IsExists(arg, block), xorr, arg, "sel", block) : static_cast<Value*>(xorr);
267268
return result;

‎ydb/library/yql/minikql/comp_nodes/mkql_map_join.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -1543,7 +1543,6 @@ class TMapJoinCoreWrapper : public TMapJoinCoreWrapperBase<IsTuple>, public TCus
15431543
const auto keysType = IsTuple ? ArrayType::get(valueType, this->LeftKeyColumns.size()) : nullptr;
15441544
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(PointerType::getUnqual(valueType)) : static_cast<Type*>(valueType);
15451545
const auto contextType = GetCompContextType(context);
1546-
const auto idxType = Type::getInt32Ty(context);
15471546
const auto statusType = Type::getInt32Ty(context);
15481547
const auto funcType = FunctionType::get(statusType, {PointerType::getUnqual(contextType), containerType, containerType, PointerType::getUnqual(valueType)}, false);
15491548

@@ -1699,7 +1698,6 @@ class TMapJoinCoreWrapper : public TMapJoinCoreWrapperBase<IsTuple>, public TCus
16991698
const auto keysType = IsTuple ? ArrayType::get(valueType, this->LeftKeyColumns.size()) : nullptr;
17001699
const auto containerType = codegen.GetEffectiveTarget() == NYql::NCodegen::ETarget::Windows ? static_cast<Type*>(PointerType::getUnqual(valueType)) : static_cast<Type*>(valueType);
17011700
const auto contextType = GetCompContextType(context);
1702-
const auto idxType = Type::getInt32Ty(context);
17031701
const auto statusType = Type::getInt32Ty(context);
17041702
const auto funcType = FunctionType::get(statusType, {PointerType::getUnqual(contextType), containerType, containerType, PointerType::getUnqual(valueType), PointerType::getUnqual(valueType), PointerType::getUnqual(valueType)}, false);
17051703

‎ydb/library/yql/minikql/comp_nodes/mkql_size.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ class TSizePrimitiveTypeWrapper : public TDecoratorCodegeneratorNode<TSizePrimit
2626

2727
#ifndef MKQL_DISABLE_CODEGEN
2828
Value* DoGenerateGetValue(const TCodegenContext& ctx, Value* value, BasicBlock*& block) const {
29+
Y_UNUSED(ctx);
2930
const uint64_t init[] = {Size, 0x100000000000000ULL};
3031
const auto size = ConstantInt::get(value->getType(), APInt(128, 2, init));
3132
return SelectInst::Create(IsEmpty(value, block), value, size, "size", block);

0 commit comments

Comments
 (0)