Skip to content

Commit d1d3fd7

Browse files
authored
Moved NotExistsIsOk setting to recursive remove settings (#8355)
1 parent 2ca83de commit d1d3fd7

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

ydb/public/lib/ydb_cli/commands/ydb_workload.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ int TWorkloadCommandBase::Run(TConfig& config) {
384384

385385
void TWorkloadCommandBase::CleanTables(NYdbWorkload::IWorkloadQueryGenerator& workloadGen, TConfig& config) {
386386
auto pathsToDelete = workloadGen.GetCleanPaths();
387-
NScheme::TRemoveDirectorySettings settings;
387+
TRemovePathRecursiveSettings settings;
388388
settings.NotExistsIsOk(true);
389389
for (const auto& path : pathsToDelete) {
390390
Cout << "Remove path " << path << "..." << Endl;

ydb/public/lib/ydb_cli/common/recursive_remove.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ TStatus RemoveDirectoryRecursive(
195195
return RemoveDirectoryRecursive(schemeClient, &tableClient, &topicClient, path, prompt, settings, removeSelf, createProgressBar);
196196
}
197197

198-
NYdb::TStatus RemovePathRecursive(NScheme::TSchemeClient& schemeClient, NTable::TTableClient& tableClient, NTopic::TTopicClient& topicClient, const TString& path, ERecursiveRemovePrompt prompt, const NScheme::TRemoveDirectorySettings& settings /*= {}*/, bool createProgressBar /*= true*/) {
198+
NYdb::TStatus RemovePathRecursive(NScheme::TSchemeClient& schemeClient, NTable::TTableClient& tableClient, NTopic::TTopicClient& topicClient, const TString& path, ERecursiveRemovePrompt prompt, const TRemovePathRecursiveSettings& settings /*= {}*/, bool createProgressBar /*= true*/) {
199199
auto entity = schemeClient.DescribePath(path).ExtractValueSync();
200200
if (!entity.IsSuccess()) {
201201
if (settings.NotExistsIsOk_ && entity.GetStatus() == EStatus::SCHEME_ERROR && entity.GetIssues().ToString().find("Path not found") != TString::npos) {

ydb/public/lib/ydb_cli/common/recursive_remove.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ enum class ERecursiveRemovePrompt {
1212
Never,
1313
};
1414

15+
struct TRemovePathRecursiveSettings : public NScheme::TRemoveDirectorySettings {
16+
FLUENT_SETTING_DEFAULT(bool, NotExistsIsOk, false);
17+
};
18+
1519
bool Prompt(ERecursiveRemovePrompt mode, const TString& path, NScheme::ESchemeEntryType type, bool first = true);
1620

1721
TStatus RemoveDirectoryRecursive(
@@ -38,7 +42,7 @@ TStatus RemovePathRecursive(
3842
NTopic::TTopicClient& topicClient,
3943
const TString& path,
4044
ERecursiveRemovePrompt prompt,
41-
const NScheme::TRemoveDirectorySettings& settings = {},
45+
const TRemovePathRecursiveSettings& settings = {},
4246
bool createProgressBar = true);
4347

4448
}

ydb/public/sdk/cpp/client/ydb_scheme/scheme.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,7 @@ using TAsyncListDirectoryResult = NThreading::TFuture<TListDirectoryResult>;
9999

100100
struct TMakeDirectorySettings : public TOperationRequestSettings<TMakeDirectorySettings> {};
101101

102-
struct TRemoveDirectorySettings : public TOperationRequestSettings<TRemoveDirectorySettings> {
103-
FLUENT_SETTING_DEFAULT(bool, NotExistsIsOk, false);
104-
};
102+
struct TRemoveDirectorySettings : public TOperationRequestSettings<TRemoveDirectorySettings> {};
105103

106104
struct TDescribePathSettings : public TOperationRequestSettings<TDescribePathSettings> {};
107105

0 commit comments

Comments
 (0)