Skip to content

Commit dbb2ffe

Browse files
authored
add implicit query params into table service config (#8064)
1 parent 0ee58bd commit dbb2ffe

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

ydb/core/kqp/compile_service/kqp_compile_service.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,8 @@ class TKqpCompileService : public TActorBootstrapped<TKqpCompileService> {
481481
bool enableColumnsWithDefault = TableServiceConfig.GetEnableColumnsWithDefault();
482482
bool enableOlapSink = TableServiceConfig.GetEnableOlapSink();
483483

484+
bool enableImplicitQueryParameterTypes = TableServiceConfig.GetEnableImplicitQueryParameterTypes();
485+
484486
auto mkqlHeavyLimit = TableServiceConfig.GetResourceManager().GetMkqlHeavyProgramMemoryLimit();
485487

486488
TableServiceConfig.Swap(event.MutableConfig()->MutableTableServiceConfig());
@@ -508,7 +510,8 @@ class TKqpCompileService : public TActorBootstrapped<TKqpCompileService> {
508510
TableServiceConfig.GetOldLookupJoinBehaviour() != oldLookupJoinBehaviour ||
509511
TableServiceConfig.GetExtractPredicateRangesLimit() != rangesLimit ||
510512
TableServiceConfig.GetResourceManager().GetMkqlHeavyProgramMemoryLimit() != mkqlHeavyLimit ||
511-
TableServiceConfig.GetIdxLookupJoinPointsLimit() != idxLookupPointsLimit) {
513+
TableServiceConfig.GetIdxLookupJoinPointsLimit() != idxLookupPointsLimit ||
514+
TableServiceConfig.GetEnableImplicitQueryParameterTypes() != enableImplicitQueryParameterTypes) {
512515

513516
QueryCache.Clear();
514517

ydb/core/kqp/session_actor/kqp_query_state.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ class TKqpQueryState : public TNonCopyable {
5353
{
5454
RequestEv.reset(ev->Release().Release());
5555

56-
if (AppData()->FeatureFlags.GetEnableImplicitQueryParameterTypes() && !RequestEv->GetYdbParameters().empty()) {
56+
bool enableImplicitQueryParameterTypes = tableServiceConfig.GetEnableImplicitQueryParameterTypes() ||
57+
AppData()->FeatureFlags.GetEnableImplicitQueryParameterTypes();
58+
if (enableImplicitQueryParameterTypes && !RequestEv->GetYdbParameters().empty()) {
5759
QueryParameterTypes = std::make_shared<std::map<TString, Ydb::Type>>();
5860
for (const auto& [name, typedValue] : RequestEv->GetYdbParameters()) {
5961
QueryParameterTypes->insert({name, typedValue.Gettype()});

ydb/core/protos/table_service_config.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,4 +276,6 @@ message TTableServiceConfig {
276276

277277
optional uint64 IdxLookupJoinPointsLimit = 58 [default = 1];
278278
optional bool OldLookupJoinBehaviour = 59 [default = true];
279+
280+
optional bool EnableImplicitQueryParameterTypes = 66 [ default = false ];
279281
};

0 commit comments

Comments
 (0)