Skip to content

Commit dcdedf9

Browse files
iddqdexiddqdex
authored
KIKIMR-20714 Удаляем LongTxService в тестах (#970)
* KIKIMR-20714 Удаляем LongTxService в тестах * fix tests * Remove test DropColumnOldScheme * fix issues * fix tests after merge
1 parent 96b3a26 commit dcdedf9

File tree

7 files changed

+21
-118
lines changed

7 files changed

+21
-118
lines changed

‎ydb/core/kqp/ut/common/columnshard.cpp

-21
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ namespace NKqp {
99
TTestHelper::TTestHelper(const TKikimrSettings& settings)
1010
: Kikimr(settings)
1111
, TableClient(Kikimr.GetTableClient())
12-
, LongTxClient(Kikimr.GetDriver())
1312
, Session(TableClient.CreateSession().GetValueSync().GetSession())
1413
{}
1514

@@ -31,26 +30,6 @@ namespace NKqp {
3130
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS, result.GetIssues().ToString());
3231
}
3332

34-
void TTestHelper::InsertData(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const std::function<void()> onBeforeCommit /*= {}*/, const EStatus opStatus /*= EStatus::SUCCESS*/) {
35-
NLongTx::TLongTxBeginResult resBeginTx = LongTxClient.BeginWriteTx().GetValueSync();
36-
UNIT_ASSERT_VALUES_EQUAL_C(resBeginTx.Status().GetStatus(), EStatus::SUCCESS, resBeginTx.Status().GetIssues().ToString());
37-
38-
auto txId = resBeginTx.GetResult().tx_id();
39-
auto batch = updates.BuildArrow();
40-
TString data = NArrow::NSerialization::TFullDataSerializer(arrow::ipc::IpcWriteOptions::Defaults()).Serialize(batch);
41-
42-
NLongTx::TLongTxWriteResult resWrite =
43-
LongTxClient.Write(txId, table.GetName(), txId, data, Ydb::LongTx::Data::APACHE_ARROW).GetValueSync();
44-
UNIT_ASSERT_VALUES_EQUAL_C(resWrite.Status().GetStatus(), opStatus, resWrite.Status().GetIssues().ToString());
45-
46-
if (onBeforeCommit) {
47-
onBeforeCommit();
48-
}
49-
50-
NLongTx::TLongTxCommitResult resCommitTx = LongTxClient.CommitTx(txId).GetValueSync();
51-
UNIT_ASSERT_VALUES_EQUAL_C(resCommitTx.Status().GetStatus(), EStatus::SUCCESS, resCommitTx.Status().GetIssues().ToString());
52-
}
53-
5433
void TTestHelper::BulkUpsert(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const Ydb::StatusIds_StatusCode& opStatus /*= Ydb::StatusIds::SUCCESS*/) {
5534
Y_UNUSED(opStatus);
5635
NKikimr::Tests::NCS::THelper helper(Kikimr.GetTestServer());

‎ydb/core/kqp/ut/common/columnshard.h

-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
#include "kqp_ut_common.h"
44
#include <ydb/library/accessor/accessor.h>
55
#include <ydb/public/lib/scheme_types/scheme_type_id.h>
6-
#include <ydb/public/sdk/cpp/client/draft/ydb_long_tx.h>
76
#include <ydb/public/sdk/cpp/client/ydb_table/table.h>
87
#include <ydb/public/sdk/cpp/client/ydb_types/status_codes.h>
98
#include <ydb/core/tx/columnshard/columnshard_ut_common.h>
@@ -64,7 +63,6 @@ namespace NKqp {
6463
private:
6564
TKikimrRunner Kikimr;
6665
NYdb::NTable::TTableClient TableClient;
67-
NYdb::NLongTx::TClient LongTxClient;
6866
NYdb::NTable::TSession Session;
6967

7068
public:
@@ -73,7 +71,6 @@ namespace NKqp {
7371
TTestActorRuntime& GetRuntime();
7472
NYdb::NTable::TSession& GetSession();
7573
void CreateTable(const TColumnTableBase& table);
76-
void InsertData(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const std::function<void()> onBeforeCommit = {}, const NYdb::EStatus opStatus = NYdb::EStatus::SUCCESS);
7774
void BulkUpsert(const TColumnTable& table, TTestHelper::TUpdatesBuilder& updates, const Ydb::StatusIds_StatusCode& opStatus = Ydb::StatusIds::SUCCESS);
7875
void BulkUpsert(const TColumnTable& table, std::shared_ptr<arrow::RecordBatch> batch, const Ydb::StatusIds_StatusCode& opStatus = Ydb::StatusIds::SUCCESS);
7976
void ReadData(const TString& query, const TString& expected, const NYdb::EStatus opStatus = NYdb::EStatus::SUCCESS);

‎ydb/core/kqp/ut/olap/kqp_olap_stats_ut.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Y_UNIT_TEST_SUITE(KqpOlapStats) {
4848
tableInserter.AddRow().Add(i).Add("test_res_" + std::to_string(i)).AddNull();
4949
}
5050

51-
testHelper.InsertData(testTable, tableInserter);
51+
testHelper.BulkUpsert(testTable, tableInserter);
5252
}
5353

5454
Sleep(TDuration::Seconds(1));
@@ -88,7 +88,7 @@ Y_UNIT_TEST_SUITE(KqpOlapStats) {
8888
for (size_t i = 0; i < inserted_rows; i++) {
8989
tableInserter.AddRow().Add(i).Add("test_res_" + std::to_string(i)).AddNull();
9090
}
91-
testHelper.InsertData(testTable, tableInserter);
91+
testHelper.BulkUpsert(testTable, tableInserter);
9292
}
9393

9494
Sleep(TDuration::Seconds(1));
@@ -135,7 +135,7 @@ Y_UNIT_TEST_SUITE(KqpOlapStats) {
135135
.Add("test_res_" + std::to_string(i + t * tables_in_store))
136136
.AddNull();
137137
}
138-
testHelper.InsertData(testTable, tableInserter);
138+
testHelper.BulkUpsert(testTable, tableInserter);
139139
}
140140

141141
Sleep(TDuration::Seconds(20));
@@ -155,4 +155,4 @@ Y_UNIT_TEST_SUITE(KqpOlapStats) {
155155
}
156156

157157
} // namespace NKqp
158-
} // namespace NKikimr
158+
} // namespace NKikimr

‎ydb/core/kqp/ut/olap/kqp_olap_ut.cpp

+4-47
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include <ydb/core/kqp/ut/common/kqp_ut_common.h>
22
#include <ydb/core/kqp/ut/common/columnshard.h>
3-
#include <ydb/public/sdk/cpp/client/draft/ydb_long_tx.h>
43

54
#include <ydb/core/sys_view/service/query_history.h>
65
#include <ydb/core/tx/columnshard/columnshard_ut_common.h>
@@ -534,67 +533,25 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
534533

535534
void WriteTestData(TKikimrRunner& kikimr, TString testTable, ui64 pathIdBegin, ui64 tsBegin, size_t rowCount, bool withSomeNulls = false) {
536535
UNIT_ASSERT(testTable != "/Root/benchTable"); // TODO: check schema instead
537-
538536
TLocalHelper lHelper(kikimr);
539537
if (withSomeNulls)
540538
lHelper.WithSomeNulls();
541-
NYdb::NLongTx::TClient client(kikimr.GetDriver());
542-
543-
NLongTx::TLongTxBeginResult resBeginTx = client.BeginWriteTx().GetValueSync();
544-
UNIT_ASSERT_VALUES_EQUAL_C(resBeginTx.Status().GetStatus(), EStatus::SUCCESS, resBeginTx.Status().GetIssues().ToString());
545-
546-
auto txId = resBeginTx.GetResult().tx_id();
547539
auto batch = lHelper.TestArrowBatch(pathIdBegin, tsBegin, rowCount);
548-
549-
TString data = NArrow::NSerialization::TFullDataSerializer(arrow::ipc::IpcWriteOptions::Defaults()).Serialize(batch);
550-
551-
NLongTx::TLongTxWriteResult resWrite =
552-
client.Write(txId, testTable, txId, data, Ydb::LongTx::Data::APACHE_ARROW).GetValueSync();
553-
UNIT_ASSERT_VALUES_EQUAL_C(resWrite.Status().GetStatus(), EStatus::SUCCESS, resWrite.Status().GetIssues().ToString());
554-
555-
NLongTx::TLongTxCommitResult resCommitTx = client.CommitTx(txId).GetValueSync();
556-
UNIT_ASSERT_VALUES_EQUAL_C(resCommitTx.Status().GetStatus(), EStatus::SUCCESS, resCommitTx.Status().GetIssues().ToString());
540+
lHelper.SendDataViaActorSystem(testTable, batch);
557541
}
558542

559543
void WriteTestDataForClickBench(TKikimrRunner& kikimr, TString testTable, ui64 pathIdBegin, ui64 tsBegin, size_t rowCount) {
560544
UNIT_ASSERT(testTable == "/Root/benchTable"); // TODO: check schema instead
561-
562545
TClickHelper lHelper(kikimr.GetTestServer());
563-
NYdb::NLongTx::TClient client(kikimr.GetDriver());
564-
565-
NLongTx::TLongTxBeginResult resBeginTx = client.BeginWriteTx().GetValueSync();
566-
UNIT_ASSERT_VALUES_EQUAL_C(resBeginTx.Status().GetStatus(), EStatus::SUCCESS, resBeginTx.Status().GetIssues().ToString());
567-
568-
auto txId = resBeginTx.GetResult().tx_id();
569546
auto batch = lHelper.TestArrowBatch(pathIdBegin, tsBegin, rowCount);
570-
TString data = NArrow::NSerialization::TFullDataSerializer(arrow::ipc::IpcWriteOptions::Defaults()).Serialize(batch);
571-
572-
NLongTx::TLongTxWriteResult resWrite =
573-
client.Write(txId, testTable, txId, data, Ydb::LongTx::Data::APACHE_ARROW).GetValueSync();
574-
UNIT_ASSERT_VALUES_EQUAL_C(resWrite.Status().GetStatus(), EStatus::SUCCESS, resWrite.Status().GetIssues().ToString());
575-
576-
NLongTx::TLongTxCommitResult resCommitTx = client.CommitTx(txId).GetValueSync();
577-
UNIT_ASSERT_VALUES_EQUAL_C(resCommitTx.Status().GetStatus(), EStatus::SUCCESS, resCommitTx.Status().GetIssues().ToString());
547+
lHelper.SendDataViaActorSystem(testTable, batch);
578548
}
579549

580550
void WriteTestDataForTableWithNulls(TKikimrRunner& kikimr, TString testTable) {
581551
UNIT_ASSERT(testTable == "/Root/tableWithNulls"); // TODO: check schema instead
582552
TTableWithNullsHelper lHelper(kikimr.GetTestServer());
583-
NYdb::NLongTx::TClient client(kikimr.GetDriver());
584-
585-
NLongTx::TLongTxBeginResult resBeginTx = client.BeginWriteTx().GetValueSync();
586-
UNIT_ASSERT_VALUES_EQUAL_C(resBeginTx.Status().GetStatus(), EStatus::SUCCESS, resBeginTx.Status().GetIssues().ToString());
587-
588-
auto txId = resBeginTx.GetResult().tx_id();
589553
auto batch = lHelper.TestArrowBatch();
590-
TString data = NArrow::NSerialization::TFullDataSerializer(arrow::ipc::IpcWriteOptions::Defaults()).Serialize(batch);
591-
592-
NLongTx::TLongTxWriteResult resWrite =
593-
client.Write(txId, testTable, txId, data, Ydb::LongTx::Data::APACHE_ARROW).GetValueSync();
594-
UNIT_ASSERT_VALUES_EQUAL_C(resWrite.Status().GetStatus(), EStatus::SUCCESS, resWrite.Status().GetIssues().ToString());
595-
596-
NLongTx::TLongTxCommitResult resCommitTx = client.CommitTx(txId).GetValueSync();
597-
UNIT_ASSERT_VALUES_EQUAL_C(resCommitTx.Status().GetStatus(), EStatus::SUCCESS, resCommitTx.Status().GetIssues().ToString());
554+
lHelper.SendDataViaActorSystem(testTable, batch);
598555
}
599556

600557
void CreateTableOfAllTypes(TKikimrRunner& kikimr) {
@@ -5307,7 +5264,7 @@ Y_UNIT_TEST_SUITE(KqpOlap) {
53075264
tableInserter.AddRow().Add(2).Add("test_res_2").Add("val1").AddNull();
53085265
tableInserter.AddRow().Add(3).Add("test_res_3").Add("val3").AddNull();
53095266
tableInserter.AddRow().Add(2).Add("test_res_2").Add("val2").AddNull();
5310-
testHelper.InsertData(testTable, tableInserter);
5267+
testHelper.BulkUpsert(testTable, tableInserter);
53115268
}
53125269
while (csController->GetIndexations().Val() == 0) {
53135270
Cout << "Wait indexation..." << Endl;

‎ydb/core/kqp/ut/scheme/kqp_constraints_ut.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include <ydb/public/sdk/cpp/client/ydb_proto/accessor.h>
66
#include <ydb/public/sdk/cpp/client/ydb_scheme/scheme.h>
77
#include <ydb/public/sdk/cpp/client/ydb_topic/topic.h>
8-
#include <ydb/public/sdk/cpp/client/draft/ydb_long_tx.h>
98
#include <ydb/core/testlib/cs_helper.h>
109
#include <ydb/core/testlib/common_helper.h>
1110
#include <ydb/core/formats/arrow/serializer/full.h>

‎ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp

+11-39
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include <ydb/public/sdk/cpp/client/ydb_proto/accessor.h>
66
#include <ydb/public/sdk/cpp/client/ydb_scheme/scheme.h>
77
#include <ydb/public/sdk/cpp/client/ydb_topic/topic.h>
8-
#include <ydb/public/sdk/cpp/client/draft/ydb_long_tx.h>
98
#include <ydb/core/testlib/cs_helper.h>
109
#include <ydb/core/testlib/common_helper.h>
1110
#include <ydb/core/formats/arrow/serializer/full.h>
@@ -5378,7 +5377,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
53785377
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
53795378
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
53805379
tableInserter.AddRow().Add(2).Add("test_res_2").Add(123);
5381-
testHelper.InsertData(testTable, tableInserter);
5380+
testHelper.BulkUpsert(testTable, tableInserter);
53825381
}
53835382

53845383
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#;[\"test_res_1\"]]]");
@@ -5407,7 +5406,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
54075406
{
54085407
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
54095408
tableInserter.AddRow().Add(3).Add("test_res_3").Add(123).Add<uint64_t>(200);
5410-
testHelper.InsertData(testTable, tableInserter);
5409+
testHelper.BulkUpsert(testTable, tableInserter);
54115410
}
54125411

54135412
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=3", "[[3;[123];[200u];[\"test_res_3\"]]]");
@@ -5444,7 +5443,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
54445443
}
54455444
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#;#;[\"test_res_1\"]]]");
54465445
}
5447-
5446+
/*
54485447
Y_UNIT_TEST(AddColumnOnSchemeChange) {
54495448
TKikimrSettings runnerSettings;
54505449
runnerSettings.WithSampleTables = false;
@@ -5471,7 +5470,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
54715470
}
54725471
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#;#;[\"test_res_1\"]]]");
54735472
}
5474-
5473+
*/
54755474
Y_UNIT_TEST(AddColumnWithStore) {
54765475
TKikimrSettings runnerSettings;
54775476
runnerSettings.WithSampleTables = false;
@@ -5494,7 +5493,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
54945493
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
54955494
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
54965495
tableInserter.AddRow().Add(2).Add("test_res_2").Add(123);
5497-
testHelper.InsertData(testTable, tableInserter);
5496+
testHelper.BulkUpsert(testTable, tableInserter);
54985497
}
54995498

55005499
testHelper.ReadData("SELECT * FROM `/Root/TableStoreTest/ColumnTableTest` WHERE id=1", "[[1;#;[\"test_res_1\"]]]");
@@ -5524,7 +5523,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
55245523
{
55255524
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
55265525
tableInserter.AddRow().Add(3).Add("test_res_3").Add(123).Add<uint64_t>(200);
5527-
testHelper.InsertData(testTable, tableInserter);
5526+
testHelper.BulkUpsert(testTable, tableInserter);
55285527
}
55295528

55305529
testHelper.ReadData("SELECT * FROM `/Root/TableStoreTest/ColumnTableTest` WHERE id=3", "[[3;[123];[200u];[\"test_res_3\"]]]");
@@ -5580,7 +5579,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
55805579
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schemaWithNull));
55815580
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
55825581
tableInserter.AddRow().Add(2).Add("test_res_2").Add(123);
5583-
testHelper.InsertData(testTable, tableInserter, {}, EStatus::GENERIC_ERROR);
5582+
testHelper.BulkUpsert(testTable, tableInserter, Ydb::StatusIds::GENERIC_ERROR);
55845583
}
55855584
{
55865585
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schemaWithNull));
@@ -5611,7 +5610,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
56115610
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
56125611
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
56135612
tableInserter.AddRow().Add(2).Add("test_res_2").Add(123);
5614-
testHelper.InsertData(testTable, tableInserter);
5613+
testHelper.BulkUpsert(testTable, tableInserter);
56155614
}
56165615
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#;[\"test_res_1\"]]]");
56175616
{
@@ -5628,7 +5627,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
56285627
}
56295628
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` ", "[[1];[2]]");
56305629
}
5631-
5630+
/*
56325631
Y_UNIT_TEST(DropColumnOnSchemeChange) {
56335632
TKikimrSettings runnerSettings;
56345633
runnerSettings.WithSampleTables = false;
@@ -5654,34 +5653,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
56545653
}
56555654
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#]]");
56565655
}
5657-
5658-
Y_UNIT_TEST(DropColumnOldScheme) {
5659-
TKikimrSettings runnerSettings;
5660-
runnerSettings.WithSampleTables = false;
5661-
TTestHelper testHelper(runnerSettings);
5662-
5663-
TVector<TTestHelper::TColumnSchema> schema = {
5664-
TTestHelper::TColumnSchema().SetName("id").SetType(NScheme::NTypeIds::Int32).SetNullable(false),
5665-
TTestHelper::TColumnSchema().SetName("resource_id").SetType(NScheme::NTypeIds::Utf8),
5666-
TTestHelper::TColumnSchema().SetName("level").SetType(NScheme::NTypeIds::Int32)
5667-
};
5668-
5669-
TTestHelper::TColumnTable testTable;
5670-
5671-
testTable.SetName("/Root/ColumnTableTest").SetPrimaryKey({"id"}).SetSharding({"id"}).SetSchema(schema);
5672-
testHelper.CreateTable(testTable);
5673-
{
5674-
auto alterQuery = TStringBuilder() << "ALTER TABLE `" << testTable.GetName() << "`DROP COLUMN resource_id;";
5675-
auto alterResult = testHelper.GetSession().ExecuteSchemeQuery(alterQuery).GetValueSync();
5676-
UNIT_ASSERT_VALUES_EQUAL_C(alterResult.GetStatus(), EStatus::SUCCESS, alterResult.GetIssues().ToString());
5677-
}
5678-
{
5679-
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
5680-
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
5681-
testHelper.InsertData(testTable, tableInserter, {}, EStatus::SUCCESS);
5682-
}
5683-
// testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#]]");
5684-
}
5656+
*/
56855657

56865658
Y_UNIT_TEST(DropColumnOldSchemeBulkUpsert) {
56875659
TKikimrSettings runnerSettings;
@@ -5729,7 +5701,7 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
57295701
TTestHelper::TUpdatesBuilder tableInserter(testTable.GetArrowSchema(schema));
57305702
tableInserter.AddRow().Add(1).Add("test_res_1").AddNull();
57315703
tableInserter.AddRow().Add(2).Add("test_res_2").Add(123);
5732-
testHelper.InsertData(testTable, tableInserter);
5704+
testHelper.BulkUpsert(testTable, tableInserter);
57335705
}
57345706
testHelper.ReadData("SELECT * FROM `/Root/ColumnTableTest` WHERE id=1", "[[1;#;[\"test_res_1\"]]]");
57355707
{

‎ydb/core/testlib/cs_helper.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -429,15 +429,14 @@ std::shared_ptr<arrow::RecordBatch> TTableWithNullsHelper::TestArrowBatch(ui64,
429429
Y_ABORT_UNLESS(bJsonDoc.AppendNull().ok());
430430
}
431431

432-
auto maybeJsonDoc = NBinaryJson::SerializeToBinaryJson(R"({"col1": "val1", "obj": {"obj_col2_int": 16}})");
433-
Y_ABORT_UNLESS(maybeJsonDoc.Defined());
432+
const auto maybeJsonDoc = std::string(R"({"col1": "val1", "obj": {"obj_col2_int": 16}})");
434433
for (size_t i = rowCount / 2 + 1; i <= rowCount; ++i) {
435434
Y_ABORT_UNLESS(bId.Append(i).ok());
436435
Y_ABORT_UNLESS(bResourceId.Append(std::to_string(i)).ok());
437436
Y_ABORT_UNLESS(bLevel.AppendNull().ok());
438437
Y_ABORT_UNLESS(bBinaryStr.Append(std::to_string(i)).ok());
439438
Y_ABORT_UNLESS(bJsonVal.AppendNull().ok());
440-
Y_ABORT_UNLESS(bJsonDoc.Append(maybeJsonDoc->Data(), maybeJsonDoc->Size()).ok());
439+
Y_ABORT_UNLESS(bJsonDoc.Append(maybeJsonDoc.data(), maybeJsonDoc.length()).ok());
441440
}
442441

443442
std::shared_ptr<arrow::Int32Array> aId;

0 commit comments

Comments
 (0)