tests/library/harness: get rid of warnings on un-closed files (#15274)

tests/library/harness: get rid of warnings on un-closed files.

`KiKiMRNode`-`Daemon` manage process of ydb node (ydbd).
`Daemon` opens stderr, stdout.
`KiKiMRNode` opens log file.

Change `Daemon` to open all those files on (every) `Daemon.start()` and close on (every) `Daemon.{stop,kill}()` instead of opening them once at `KiKiMRNode`-`Daemon` construction and never closing.

Author: ijon

ydb/tests/library/harness/daemon.py

@@ -60,6 +60,7 @@ def __init__(
         timeout,
         stdout_file="/dev/null",
         stderr_file="/dev/null",
+        aux_file=None,
         stderr_on_error_lines=0,
         core_pattern=None,
     ):
@@ -71,8 +72,27 @@ def __init__(
         self.killed = False
         self.__core_pattern = core_pattern
         self.logger = logger.getChild(self.__class__.__name__)
-        self.__stdout_file = open(stdout_file, mode='wb')
-        self.__stderr_file = open(stderr_file, mode='wb')
+        self.__stdout_file_name = stdout_file
+        self.__stderr_file_name = stderr_file
+        self.__aux_file_name = aux_file
+        self.__stdout_file = None
+        self.__stderr_file = None
+        self.__aux_file = None
+
+    def __open_output_files(self):
+        self.__stdout_file = open(self.__stdout_file_name, mode='w+b')
+        self.__stderr_file = open(self.__stderr_file_name, mode='w+b')
+        if self.__aux_file_name is not None:
+            self.__aux_file = open(self.__aux_file_name, mode='w+b')
+
+    def __close_output_files(self):
+        self.__stdout_file.close()
+        self.__stdout_file = None
+        self.__stderr_file.close()
+        self.__stderr_file = None
+        if self.__aux_file_name is not None:
+            self.__aux_file.close()
+            self.__aux_file = None
 
     @property
     def daemon(self):
@@ -81,14 +101,14 @@ def daemon(self):
     @property
     def stdout_file_name(self):
         if self.__stdout_file is not sys.stdout:
-            return os.path.abspath(self.__stdout_file.name)
+            return os.path.abspath(self.__stdout_file_name)
         else:
             return None
 
     @property
     def stderr_file_name(self):
         if self.__stderr_file is not sys.stderr:
-            return os.path.abspath(self.__stderr_file.name)
+            return os.path.abspath(self.__stderr_file_name)
         else:
             return None
 
@@ -98,20 +118,21 @@ def is_alive(self):
     def start(self):
         if self.is_alive():
             return
-        stderr_stream = self.__stderr_file
+        self.__open_output_files()
         self.__daemon = process.execute(
             self.__command,
             check_exit_code=False,
             cwd=self.__cwd,
             stdout=self.__stdout_file,
-            stderr=stderr_stream,
+            stderr=self.__stderr_file,
             wait=False,
             core_pattern=self.__core_pattern,
         )
         wait_for(self.is_alive, self.__timeout)
 
         if not self.is_alive():
             self.__check_before_fail()
+            self.__close_output_files()
             raise DaemonError(
                 "Unexpectedly finished on start",
                 exit_code=self.__daemon.exit_code,
@@ -141,6 +162,7 @@ def __check_can_launch_stop(self, stop_type):
 
         if not self.is_alive():
             self.__check_before_fail()
+            self.__close_output_files()
             raise DaemonError(
                 "Unexpectedly finished before %s" % stop_type,
                 exit_code=self.__daemon.exit_code,
@@ -176,6 +198,7 @@ def stop(self):
             wait_for(lambda: not self.is_alive(), self.__timeout)
             is_killed = True
         self.__check_before_end_stop("stop")
+        self.__close_output_files()
 
         if not is_killed:
             exit_code = self.__daemon.exit_code
@@ -201,6 +224,7 @@ def kill(self):
         self.killed = True
 
         self.__check_before_end_stop("kill")
+        self.__close_output_files()
 
 
 @six.add_metaclass(abc.ABCMeta)

ydb/tests/library/harness/kikimr_runner.py

@@ -89,13 +89,17 @@ def __init__(self, node_id, config_path, port_allocator, cluster_name, configura
         )
 
         if configurator.use_log_files:
-            self.__log_file = tempfile.NamedTemporaryFile(dir=self.__working_dir, prefix="logfile_", suffix=".log", delete=False)
+            # use NamedTemporaryFile only as a unique name generator
+            log_file = tempfile.NamedTemporaryFile(dir=self.__working_dir, prefix="logfile_", suffix=".log", delete=False)
+            self.__log_file_name = log_file.name
+            log_file.close()
             kwargs = {
                 "stdout_file": os.path.join(self.__working_dir, "stdout"),
-                "stderr_file": os.path.join(self.__working_dir, "stderr")
+                "stderr_file": os.path.join(self.__working_dir, "stderr"),
+                "aux_file": self.__log_file_name,
                 }
         else:
-            self.__log_file = None
+            self.__log_file_name = None
             kwargs = {
                 "stdout_file": "/dev/stdout",
                 "stderr_file": "/dev/stderr"
@@ -168,9 +172,9 @@ def __make_run_command(self):
                 "--node-kind=%s" % self.__configurator.node_kind
             )
 
-        if self.__log_file is not None:
+        if self.__log_file_name is not None:
             command.append(
-                "--log-file-name=%s" % self.__log_file.name,
+                "--log-file-name=%s" % self.__log_file_name,
             )
 
         command.extend(