Skip to content

Commit e4f7525

Browse files
committed
fix review comments
1 parent 02098b3 commit e4f7525

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

ydb/library/yql/dq/actors/input_transforms/dq_input_transform_lookup.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -386,10 +386,8 @@ THashMap<TStringBuf, size_t> GetNameToIndex(const ::google::protobuf::RepeatedPt
386386

387387
THashMap<TStringBuf, size_t> GetNameToIndex(const NMiniKQL::TStructType* type) {
388388
THashMap<TStringBuf, size_t> result;
389-
for (ui32 i = 0; i != type->GetMembersCount()//names.size()
390-
; ++i) {
391-
auto name = type->GetMemberName(i);
392-
result[name] = i;
389+
for (ui32 i = 0; i != type->GetMembersCount(); ++i) {
390+
result[type->GetMemberName(i)] = i;
393391
}
394392
return result;
395393
}
@@ -432,12 +430,12 @@ std::pair<IDqComputeActorAsyncInput*, NActors::IActor*> CreateInputTransformStre
432430

433431
const auto rightRowType = DeserializeStructType(settings.GetRightSource().GetSerializedRowType(), args.TypeEnv);
434432

435-
auto leftJoinColumns = GetNameToIndex(narrowInputRowType);
433+
auto inputColumns = GetNameToIndex(narrowInputRowType);
436434
auto rightJoinColumns = GetNameToIndex(settings.GetRightJoinKeyNames());
437435

438436
auto leftJoinColumnIndexes = GetJoinColumnIndexes(
439437
settings.GetLeftJoinKeyNames(),
440-
leftJoinColumns);
438+
inputColumns);
441439
auto rightJoinColumnIndexes = GetJoinColumnIndexes(rightRowType, rightJoinColumns);
442440
Y_ABORT_UNLESS(rightJoinColumnIndexes.size() == rightJoinColumns.size());
443441
Y_ABORT_UNLESS(leftJoinColumnIndexes.size() == rightJoinColumnIndexes.size());

0 commit comments

Comments
 (0)