Skip to content

Commit e5d8925

Browse files
fix
1 parent 7aa1928 commit e5d8925

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

ydb/core/tx/columnshard/engines/changes/general_compaction.cpp

+5-6
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ void TGeneralCompactColumnEngineChanges::BuildAppendedPortionsByChunks(TConstruc
104104
auto dataSchema = context.SchemaVersions.GetSchema(p.GetPortionInfo().GetMinSnapshot());
105105
auto loader = dataSchema->GetColumnLoaderOptional(columnId);
106106
std::vector<const TColumnRecord*> records;
107-
std::vector<std::shared_ptr<IPortionDataChunk>> chunks;
107+
std::vector<IPortionColumnChunk::TPtr> chunks;
108108
if (!p.ExtractColumnChunks(columnId, records, chunks)) {
109109
AFL_VERIFY(!loader);
110110
records = {nullptr};
@@ -179,11 +179,10 @@ void TGeneralCompactColumnEngineChanges::BuildAppendedPortionsByChunks(TConstruc
179179
std::shared_ptr<TDefaultSchemaDetails> schemaDetails(new TDefaultSchemaDetails(resultSchema, SaverContext, stats));
180180

181181
for (ui32 i = 0; i < columnChunks.begin()->second.size(); ++i) {
182-
std::map<ui32, std::vector<std::shared_ptr<IPortionDataChunk>>> portionColumns;
182+
std::map<ui32, std::vector<IPortionColumnChunk::TPtr>> portionColumns;
183183
for (auto&& p : columnChunks) {
184184
portionColumns.emplace(p.first, p.second[i].GetChunks());
185185
}
186-
resultSchema->GetIndexInfo().BuildIndexes(portionColumns);
187186
batchSlices.emplace_back(portionColumns, schemaDetails, context.Counters.SplitterCounters, GetSplitSettings());
188187
}
189188
TSimilarSlicer slicer(GetSplitSettings().GetExpectedPortionSize());
@@ -192,13 +191,13 @@ void TGeneralCompactColumnEngineChanges::BuildAppendedPortionsByChunks(TConstruc
192191
ui32 recordIdx = 0;
193192
for (auto&& i : packs) {
194193
TGeneralSerializedSlice slice(std::move(i));
195-
auto b = batchResult->Slice(recordIdx, slice.GetRecordsCountVerified());
196-
std::vector<std::vector<std::shared_ptr<IPortionDataChunk>>> chunksByBlobs = slice.GroupChunksByBlobs();
194+
auto b = batchResult->Slice(recordIdx, slice.GetRecordsCount());
195+
std::vector<std::vector<IPortionColumnChunk::TPtr>> chunksByBlobs = slice.GroupChunksByBlobs();
197196
AppendedPortions.emplace_back(TPortionInfoWithBlobs::BuildByBlobs(chunksByBlobs, nullptr, GranuleMeta->GetPathId(), resultSchema->GetSnapshot(), SaverContext.GetStorageOperator()));
198197
NArrow::TFirstLastSpecialKeys primaryKeys(slice.GetFirstLastPKBatch(resultSchema->GetIndexInfo().GetReplaceKey()));
199198
NArrow::TMinMaxSpecialKeys snapshotKeys(b, TIndexInfo::ArrowSchemaSnapshot());
200199
AppendedPortions.back().GetPortionInfo().AddMetadata(*resultSchema, primaryKeys, snapshotKeys, SaverContext.GetTierName());
201-
recordIdx += slice.GetRecordsCountVerified();
200+
recordIdx += slice.GetRecordsCount();
202201
}
203202
}
204203
}

0 commit comments

Comments
 (0)