Skip to content

Commit ea37d52

Browse files
authored
fix cannonical and timeout using (#10013)
1 parent 2b39cf8 commit ea37d52

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

ydb/tests/olap/lib/ydb_cli.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -178,25 +178,21 @@ def _get_cmd(self) -> list[str]:
178178
'--include', str(self.query_num),
179179
'--iterations', str(self.iterations),
180180
'--plan', self._plan_path,
181+
'--global-timeout', f'{self.timeout}s',
181182
'--verbose'
182183
]
183184
query_preffix = get_external_param('query-prefix', '')
184185
if query_preffix:
185186
cmd += ['--query-settings', query_preffix]
186187
if self.check_canonical:
187-
cmd.append('--check-cannonical')
188+
cmd.append('--check-canonical')
188189
return cmd
189190

190191
def _exec_cli(self) -> None:
191-
try:
192-
process = yatest.common.process.execute(self._get_cmd(), wait=False, check_exit_code=False)
193-
process.wait(check_exit_code=False, timeout=self.timeout)
194-
self._process_returncode(process.returncode, process.stderr.decode('utf-8', 'replace'))
195-
except (yatest.common.process.TimeoutError, yatest.common.process.ExecutionTimeoutError):
196-
self._process_returncode(0, process.stderr.decode('utf-8', 'replace'))
197-
self._add_error(f'Timeout {self.timeout}s expeared.')
192+
process = yatest.common.process.execute(self._get_cmd(), check_exit_code=False)
198193
self.result.stdout = process.stdout.decode('utf-8', 'replace')
199194
self.result.stderr = process.stderr.decode('utf-8', 'replace')
195+
self._process_returncode(process.returncode, self.result.stderr)
200196

201197
def process(self) -> YdbCliHelper.WorkloadRunResult:
202198
try:

0 commit comments

Comments
 (0)