Fixed uncaught exception in TS3FileWriteActor

Author: GrigoriyPA

ydb/library/yql/providers/s3/actors/yql_s3_write_actor.cpp

@@ -139,7 +139,7 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
         const TString& token)
         : TxId(txId)
         , Gateway(std::move(gateway))
-        , Credentials(std::move(crdentials))
+        , AuthInfo(crdentials.GetAuthInfo())
         , RetryPolicy(retryPolicy)
         , ActorSystem(TActivationContext::ActorSystem())
         , Key(key)
@@ -155,22 +155,21 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
     void Bootstrap(const TActorId& parentId) {
         ParentId = parentId;
         LOG_D("TS3FileWriteActor", "Bootstrap by " << ParentId << " for Key: [" << Key << "], Url: [" << Url << "], request id: [" << RequestId << "]");
-        auto authInfo = Credentials.GetAuthInfo();
         if (DirtyWrite && Parts->IsSealed() && Parts->Size() <= 1) {
             Become(&TS3FileWriteActor::SinglepartWorkingStateFunc);
             const size_t size = Max<size_t>(Parts->Volume(), 1);
             InFlight += size;
             SentSize += size;
             Gateway->Upload(Url,
-                IHTTPGateway::MakeYcHeaders(RequestId, authInfo.GetToken(), {}, authInfo.GetAwsUserPwd(), authInfo.GetAwsSigV4()),
+                IHTTPGateway::MakeYcHeaders(RequestId, AuthInfo.GetToken(), {}, AuthInfo.GetAwsUserPwd(), AuthInfo.GetAwsSigV4()),
                 Parts->Pop(),
                 std::bind(&TS3FileWriteActor::OnUploadFinish, ActorSystem, SelfId(), ParentId, Key, Url, RequestId, size, std::placeholders::_1),
                 true,
                 RetryPolicy);
         } else {
             Become(&TS3FileWriteActor::MultipartInitialStateFunc);
             Gateway->Upload(Url + "?uploads",
-                IHTTPGateway::MakeYcHeaders(RequestId, authInfo.GetToken(), {}, authInfo.GetAwsUserPwd(), authInfo.GetAwsSigV4()),
+                IHTTPGateway::MakeYcHeaders(RequestId, AuthInfo.GetToken(), {}, AuthInfo.GetAwsUserPwd(), AuthInfo.GetAwsSigV4()),
                 0,
                 std::bind(&TS3FileWriteActor::OnUploadsCreated, ActorSystem, SelfId(), ParentId, RequestId, std::placeholders::_1),
                 false,
@@ -367,9 +366,8 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
             Tags.emplace_back();
             InFlight += size;
             SentSize += size;
-            auto authInfo = Credentials.GetAuthInfo();
             Gateway->Upload(Url + "?partNumber=" + std::to_string(index + 1) + "&uploadId=" + UploadId,
-                IHTTPGateway::MakeYcHeaders(RequestId, authInfo.GetToken(), {}, authInfo.GetAwsUserPwd(), authInfo.GetAwsSigV4()),
+                IHTTPGateway::MakeYcHeaders(RequestId, AuthInfo.GetToken(), {}, AuthInfo.GetAwsUserPwd(), AuthInfo.GetAwsSigV4()),
                 std::move(part),
                 std::bind(&TS3FileWriteActor::OnPartUploadFinish, ActorSystem, SelfId(), ParentId, size, index, RequestId, std::placeholders::_1),
                 true,
@@ -395,9 +393,8 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
         for (const auto& tag : Tags)
             xml << "<Part><PartNumber>" << ++i << "</PartNumber><ETag>" << tag << "</ETag></Part>" << Endl;
         xml << "</CompleteMultipartUpload>" << Endl;
-        auto authInfo = Credentials.GetAuthInfo();
         Gateway->Upload(Url + "?uploadId=" + UploadId,
-            IHTTPGateway::MakeYcHeaders(RequestId, authInfo.GetToken(), "application/xml", authInfo.GetAwsUserPwd(), authInfo.GetAwsSigV4()),
+            IHTTPGateway::MakeYcHeaders(RequestId, AuthInfo.GetToken(), "application/xml", AuthInfo.GetAwsUserPwd(), AuthInfo.GetAwsSigV4()),
             xml,
             std::bind(&TS3FileWriteActor::OnMultipartUploadFinish, ActorSystem, SelfId(), ParentId, Key, Url, RequestId, SentSize, std::placeholders::_1),
             false,
@@ -412,9 +409,8 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
             return;
         }
 
-        auto authInfo = Credentials.GetAuthInfo();
         Gateway->Delete(Url + "?uploadId=" + UploadId,
-            IHTTPGateway::MakeYcHeaders(RequestId, authInfo.GetToken(), "application/xml", authInfo.GetAwsUserPwd(), authInfo.GetAwsSigV4()),
+            IHTTPGateway::MakeYcHeaders(RequestId, AuthInfo.GetToken(), "application/xml", AuthInfo.GetAwsUserPwd(), AuthInfo.GetAwsSigV4()),
             std::bind(&TS3FileWriteActor::OnMultipartUploadAbort, ActorSystem, SelfId(), TxId, RequestId, std::placeholders::_1),
             RetryPolicy);
         UploadId.clear();
@@ -425,7 +421,7 @@ class TS3FileWriteActor : public TActorBootstrapped<TS3FileWriteActor> {
 
     const TTxId TxId;
     const IHTTPGateway::TPtr Gateway;
-    const TS3Credentials Credentials;
+    const TS3Credentials::TAuthInfo AuthInfo;
     const IHTTPGateway::TRetryPolicy::TPtr RetryPolicy;
 
     TActorSystem* const ActorSystem;

ydb/tests/tools/kqprun/kqprun.cpp

@@ -232,8 +232,19 @@ void RunMain(int argc, const char* argv[]) {
     RunScript(executionOptions, runnerOptions);
 }
 
+void KqprunTerminateHandler() {
+    NColorizer::TColors colors = NColorizer::AutoColors(Cerr);
+
+    Cerr << colors.Red() << "======= terminate() call stack ========" << colors.Default() << Endl;
+    FormatBackTrace(&Cerr);
+    Cerr << colors.Red() << "=======================================" << colors.Default() << Endl;
+
+    abort();
+}
 
 int main(int argc, const char* argv[]) {
+    std::set_terminate(KqprunTerminateHandler);
+
     try {
         RunMain(argc, argv);
     } catch (...) {