Skip to content

Commit f5de617

Browse files
authored
ci: don't override old PR build status comment on every build (#1284)
1 parent 3aa1a41 commit f5de617

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

.github/scripts/tests/comment-pr.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,18 @@ def main():
2323
elif args.fail:
2424
color = 'red'
2525

26+
run_number = int(os.environ.get("GITHUB_RUN_NUMBER"))
2627
build_preset = os.environ["BUILD_PRESET"]
2728

2829
gh = Github(auth=GithubAuth.Token(os.environ["GITHUB_TOKEN"]))
2930

3031
with open(os.environ["GITHUB_EVENT_PATH"]) as fp:
3132
event = json.load(fp)
3233

33-
prnum = event.get("pull_request")
34-
if not prnum is None:
35-
pr = gh.create_from_raw_data(PullRequest, prnum)
36-
update_pr_comment_text(pr, build_preset, color, args.text.read().rstrip(), args.rewrite)
34+
pr = gh.create_from_raw_data(PullRequest, event["pull_request"])
35+
update_pr_comment_text(pr, build_preset, run_number, color, args.text.read().rstrip(), args.rewrite)
3736

3837

3938
if __name__ == "__main__":
40-
main()
39+
if os.environ.get('GITHUB_EVENT_NAME', '').startswith('pull_request'):
40+
main()

.github/scripts/tests/generate-summary.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,9 @@ def main():
347347
else:
348348
color = 'green'
349349

350-
update_pr_comment_text(pr, args.build_preset, color, text='\n'.join(text), rewrite=False)
350+
run_number = int(os.environ.get("GITHUB_RUN_NUMBER"))
351+
352+
update_pr_comment_text(pr, args.build_preset, run_number, color, text='\n'.join(text), rewrite=False)
351353

352354

353355
if __name__ == "__main__":

.github/scripts/tests/gh_status.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ def get_platform_name():
1111
return f'{platform.system().lower()}-{platform.machine()}'
1212

1313

14-
def update_pr_comment_text(pr: PullRequest, build_preset: str, color: str, text: str, rewrite: bool):
14+
def update_pr_comment_text(pr: PullRequest, build_preset: str, run_number: int, color: str, text: str, rewrite: bool):
1515
platform_name = get_platform_name()
16-
header = f"<!-- status pr={pr.number}, preset={platform_name}-{build_preset} -->"
16+
header = f"<!-- status pr={pr.number}, preset={platform_name}-{build_preset}, run={run_number} -->"
1717

1818
body = comment = None
1919
for c in pr.get_issue_comments():

0 commit comments

Comments
 (0)