Skip to content

Commit f711ded

Browse files
authored
YQL-17542 remove unused abstraction (#1184)
1 parent f78fb7b commit f711ded

File tree

1 file changed

+11
-26
lines changed

1 file changed

+11
-26
lines changed

ydb/library/yql/providers/dq/task_runner/tasks_runner_local.cpp

+11-26
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,13 @@ class TLocalTaskRunner: public ITaskRunner {
193193

194194
/*______________________________________________________________________________________________*/
195195

196-
class TAbstractFactory: public IProxyFactory {
196+
class TLocalFactory: public IProxyFactory {
197197
public:
198-
TAbstractFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
198+
TLocalFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
199199
NKikimr::NMiniKQL::TComputationNodeFactory compFactory,
200200
TTaskTransformFactory taskTransformFactory,
201-
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache)
201+
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache,
202+
bool terminateOnError)
202203
: DeterministicMode(!!GetEnv("YQL_DETERMINISTIC_MODE"))
203204
, RandomProvider(
204205
DeterministicMode
@@ -210,6 +211,7 @@ class TAbstractFactory: public IProxyFactory {
210211
: CreateDefaultTimeProvider())
211212
, FunctionRegistry(functionRegistry)
212213
, TaskTransformFactory(std::move(taskTransformFactory))
214+
, TerminateOnError(terminateOnError)
213215
{
214216
ExecutionContext.FuncRegistry = FunctionRegistry;
215217
ExecutionContext.ComputationFactory = compFactory;
@@ -218,29 +220,6 @@ class TAbstractFactory: public IProxyFactory {
218220
ExecutionContext.PatternCache = patternCache;
219221
}
220222

221-
protected:
222-
bool DeterministicMode;
223-
TIntrusivePtr<IRandomProvider> RandomProvider;
224-
TIntrusivePtr<ITimeProvider> TimeProvider;
225-
const NKikimr::NMiniKQL::IFunctionRegistry* FunctionRegistry;
226-
TTaskTransformFactory TaskTransformFactory;
227-
228-
NDq::TDqTaskRunnerContext ExecutionContext;
229-
};
230-
231-
/*______________________________________________________________________________________________*/
232-
233-
class TLocalFactory: public TAbstractFactory {
234-
public:
235-
TLocalFactory(const NKikimr::NMiniKQL::IFunctionRegistry* functionRegistry,
236-
NKikimr::NMiniKQL::TComputationNodeFactory compFactory,
237-
TTaskTransformFactory taskTransformFactory,
238-
std::shared_ptr<NKikimr::NMiniKQL::TComputationPatternLRUCache> patternCache,
239-
bool terminateOnError)
240-
: TAbstractFactory(functionRegistry, compFactory, taskTransformFactory, patternCache)
241-
, TerminateOnError(terminateOnError)
242-
{ }
243-
244223
ITaskRunner::TPtr GetOld(const TDqTaskSettings& task, const TString& traceId) override {
245224
return new TLocalTaskRunner(task, Get(task, NDqProto::DQ_STATS_MODE_BASIC, traceId));
246225
}
@@ -287,6 +266,12 @@ class TLocalFactory: public TAbstractFactory {
287266
}
288267

289268
private:
269+
bool DeterministicMode;
270+
TIntrusivePtr<IRandomProvider> RandomProvider;
271+
TIntrusivePtr<ITimeProvider> TimeProvider;
272+
const NKikimr::NMiniKQL::IFunctionRegistry* FunctionRegistry;
273+
TTaskTransformFactory TaskTransformFactory;
274+
NDq::TDqTaskRunnerContext ExecutionContext;
290275
const bool TerminateOnError;
291276
};
292277

0 commit comments

Comments
 (0)