Skip to content

Commit 824e0a2

Browse files
authored
Migrate from tsc to rollup for the build process (#38)
this PR migrates the build chain from tsc to rollup, as part of the changes discovered in the investigation from this [PR](yext/chat-ui-react#38): J=CLIP-556 TEST=manual see that all unit tests and the two test site still works as expected published an alpha version `[0.7.0-alpha.38.2](https://www.npmjs.com/package/@yext/chat-headless/v/0.7.0-alpha.38.2)` of headless and alpha version `[0.6.0-alpha.38.3](https://www.npmjs.com/package/@yext/chat-headless-react/v/0.6.0-alpha.38.3)` of headless-react, and see that it still works as expected in vite/pagesjs and sonic/alpha. Will publish v0.7.0 of headless once merged. Then update headless-react dep in a separate PR to publish 0.6.0
1 parent 1fc5e8a commit 824e0a2

23 files changed

+272
-262
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ module.exports = {
88
"**/index.ts",
99
"**/build",
1010
"**/coverage",
11+
"rollup.config.mjs",
1112
"*.d.ts",
1213
],
1314
parserOptions: {

apps/test-site/craco.config.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

apps/test-site/package.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
"web-vitals": "^2.1.4"
1515
},
1616
"scripts": {
17-
"start": "craco start",
18-
"build": "craco build",
19-
"test": "craco test"
17+
"start": "react-scripts start",
18+
"build": "react-scripts build",
19+
"test": "react-scripts test"
2020
},
2121
"browserslist": {
2222
"production": [
@@ -29,8 +29,5 @@
2929
"last 1 firefox version",
3030
"last 1 safari version"
3131
]
32-
},
33-
"devDependencies": {
34-
"@craco/craco": "^7.1.0"
3532
}
3633
}

0 commit comments

Comments
 (0)