Skip to content

Commit 5674fa5

Browse files
committed
Add docstring for sync
1 parent d7e32be commit 5674fa5

File tree

2 files changed

+69
-11
lines changed

2 files changed

+69
-11
lines changed

sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py

+56-11
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,20 @@ def _convert_xml_to_object(queue_name, et, clazz):
5656

5757

5858
class ServiceBusManagementClient:
59+
"""Use this client to create, update, list, and delete resources of a ServiceBus namespace
60+
61+
:param str fully_qualified_namespace:
62+
:param credential:
63+
:type credential: Union[TokenCredential, ServiceBusSharedKeyCredential]
64+
:keyword Pipeline pipeline: If omitted, the standard pipeline is used.
65+
:keyword HttpTransport transport: If omitted, the standard pipeline is used.
66+
:keyword List[HTTPPolicy] policies: If omitted, the standard pipeline is used.
67+
68+
For keyword arguments, refer to TODO: add a link here
69+
"""
5970

6071
def __init__(self, fully_qualified_namespace, credential, **kwargs):
6172
# type: (str, Union[TokenCredential, ServiceBusSharedKeyCredential], Dict[str, Any]) -> None
62-
"""
63-
:param fully_qualified_namespace:
64-
:param kwargs:
65-
"""
6673
self.fully_qualified_namespace = fully_qualified_namespace
6774
self._credential = credential
6875
self._endpoint = "https://" + fully_qualified_namespace
@@ -95,12 +102,14 @@ def _build_pipeline(self, **kwargs): # pylint: disable=no-self-use
95102
return Pipeline(transport, policies)
96103

97104
@classmethod
98-
def from_connection_string(cls, connection_string):
99-
# type: (str) -> ServiceBusManagementClient
100-
"""
105+
def from_connection_string(cls, connection_string, **kwargs):
106+
# type: (str, Any) -> ServiceBusManagementClient
107+
"""Create a client from connection string
101108
102109
:param str connection_string:
103-
:return:
110+
:keyword Pipeline pipeline: If omitted, the standard pipeline is used.
111+
:keyword HttpTransport transport: If omitted, the standard pipeline is used.
112+
:keyword List[HTTPPolicy] policies: If omitted, the standard pipeline is used.
104113
"""
105114
endpoint, shared_access_key_name, shared_access_key, _ = parse_conn_str(connection_string)
106115
if "//" in endpoint:
@@ -143,15 +152,30 @@ def _list_queues(self, skip, max_count, clazz):
143152

144153
def get_queue(self, queue_name):
145154
# type: (str) -> QueueDescription
155+
"""Get a QueueDescription
156+
157+
:param str queue_name: The name of the queue
158+
"""
146159
return self._get_queue_object(queue_name, QueueDescription)
147160

148161
def get_queue_runtime_info(self, queue_name):
149162
# type: (str) -> QueueRuntimeInfo
163+
"""Get the runtime information of a queue
164+
165+
:param str queue_name: The name of the queue
166+
"""
150167
return self._get_queue_object(queue_name, QueueRuntimeInfo)
151168

152169
def create_queue(self, queue):
153170
# type: (Union[str, QueueDescription]) -> QueueDescription
154-
"""Create a queue"""
171+
"""Create a queue
172+
173+
:param queue: The queue name or a `QueueDescription` instance. When it's a str, it will be the name
174+
of the created queue. Other properties of the created queue will have default values decided by the
175+
ServiceBus. Use a `QueueDesceiption` if you want to set queue properties other than the queue name.
176+
:type queue: Union[str, QueueDescription].
177+
:returns: `QueueDescription` returned from ServiceBus.
178+
"""
155179

156180
try: # queue is a QueueDescription
157181
queue_name = queue.queue_name
@@ -179,7 +203,13 @@ def create_queue(self, queue):
179203

180204
def update_queue(self, queue_description):
181205
# type: (QueueDescription) -> QueueDescription
182-
"""Update a queue"""
206+
"""
207+
208+
:param queue_description: The properties of this `QueueDescription` will be applied to the queue in
209+
ServiceBus. Only a portion of properties can be updated.
210+
Refer to https://docs.microsoft.com/en-us/rest/api/servicebus/update-queue.
211+
:type queue_description: QueueDescription
212+
"""
183213
if not queue_description.queue_name:
184214
raise ValueError("queue_description must have a non-empty queue_name")
185215

@@ -205,7 +235,10 @@ def update_queue(self, queue_description):
205235

206236
def delete_queue(self, queue_name):
207237
# type: (str) -> None
208-
"""Create a queue"""
238+
"""Delete a queue
239+
240+
:param str queue_name: The name of the queue
241+
"""
209242

210243
if not queue_name:
211244
raise ValueError("queue_name must not be None or empty")
@@ -214,8 +247,20 @@ def delete_queue(self, queue_name):
214247

215248
def list_queues(self, skip=0, max_count=100):
216249
# type: (int, int) -> List[QueueDescription]
250+
"""List the queues of a ServiceBus namespace
251+
252+
:param int skip: skip this number of queues
253+
:param int max_count: return at most this number of queues if there are more than this number in
254+
the ServiceBus namespace
255+
"""
217256
return self._list_queues(skip, max_count, QueueDescription)
218257

219258
def list_queues_runtime_info(self, skip=0, max_count=100):
220259
# type: (int, int) -> List[QueueRuntimeInfo]
260+
"""List the queues runtime info of a ServiceBus namespace
261+
262+
:param int skip: skip this number of queues
263+
:param int max_count: return at most this number of queues if there are more than this number in
264+
the ServiceBus namespace
265+
"""
221266
return self._list_queues(skip, max_count, QueueRuntimeInfo)

sdk/servicebus/azure-servicebus/azure/servicebus/management/_shared_key_policy.py

+13
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,18 @@
55

66
import time
77
import six
8+
from azure.core.pipeline import PipelineRequest
89
from azure.core.pipeline.policies import SansIOHTTPPolicy
910
from .._base_handler import ServiceBusSharedKeyCredential
1011

1112

1213
class ServiceBusSharedKeyCredentialPolicy(SansIOHTTPPolicy):
14+
"""A policy that put token generated by ServiceBusSharedKeyCredential into HTTP request header
15+
16+
:param str endpoint:
17+
:param ServiceBusSharedKeyCredential credential:
18+
:param str name:
19+
"""
1320
def __init__(self, endpoint, credential, name):
1421
# type: (str, ServiceBusSharedKeyCredential, str) -> None
1522
super(ServiceBusSharedKeyCredentialPolicy, self).__init__()
@@ -29,5 +36,11 @@ def _update_token(self):
2936
self._token = access_token.decode("utf-8")
3037

3138
def on_request(self, request):
39+
# type: (PipelineRequest) -> None
40+
"""Adds an Authorization header to request and sends request to next policy.
41+
42+
:param request: The pipeline request object
43+
:type request: ~azure.core.pipeline.PipelineRequest
44+
"""
3245
self._update_token()
3346
request.http_request.headers[self._name] = self._token

0 commit comments

Comments
 (0)