Update server/src/main/java/org/elasticsearch/index/fieldvisitor/FieldsVisitor.java

ywelsch · original-brownbear · web-flow · commit 5ed5b0afc2e0 · 2019-11-09T14:31:18.000+01:00
more efficient UID decoding

Co-Authored-By: Armin Braun &lt;me@obrown.io&gt;
diff --git a/server/src/main/java/org/elasticsearch/index/fieldvisitor/FieldsVisitor.java b/server/src/main/java/org/elasticsearch/index/fieldvisitor/FieldsVisitor.java
@@ -115,7 +115,7 @@ public void binaryField(FieldInfo fieldInfo, BytesRef value) {
         if (sourceFieldName.equals(fieldInfo.name)) {
             source = new BytesArray(value);
         } else if (IdFieldMapper.NAME.equals(fieldInfo.name)) {
-            id = Uid.decodeId(new BytesArray(value).array());
+            id = Uid.decodeId(value.bytes, value.offset, value.length)
         } else {
             addValue(fieldInfo.name, value);
         }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ public void binaryField(FieldInfo fieldInfo, BytesRef value) {`
`115`	`115`	`if (sourceFieldName.equals(fieldInfo.name)) {`
`116`	`116`	`source = new BytesArray(value);`
`117`	`117`	`} else if (IdFieldMapper.NAME.equals(fieldInfo.name)) {`
`118`		`- id = Uid.decodeId(new BytesArray(value).array());`
	`118`	`+ id = Uid.decodeId(value.bytes, value.offset, value.length)`
`119`	`119`	`} else {`
`120`	`120`	`addValue(fieldInfo.name, value);`
`121`	`121`	`}`