Skip to content

Restructure to use ember-cli-deploy-plugin, and complete rename to em… #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lukemelia
Copy link
Contributor

…ber-cli-deploy-revision-key

Contributes to ember-cli-deploy/ember-cli-deploy#180

@lukemelia lukemelia force-pushed the plugin-base-class-restructure branch from 8743b8b to 439d4b5 Compare July 12, 2015 06:26
var red = chalk.red;

var validateConfig = require('./lib/utilities/validate-config');
var DeployPluginBase = require('ember-cli-deploy-plugin');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lukemelia, I may be having a massive brain fart but where does ember-cli-deploy-plugin come from? I can't see it in the ember-cli-deploy/ember-cli-deploy#180 which is where I would have expected it to be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukemelia lukemelia force-pushed the plugin-base-class-restructure branch from 439d4b5 to 0202e53 Compare July 13, 2015 20:20
achambers pushed a commit that referenced this pull request Jul 13, 2015
Restructure to use ember-cli-deploy-plugin, and complete rename to em…
@achambers achambers merged commit 972c9d1 into ember-cli-deploy:master Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants