cmd/digraph: use ReadString rather than bufio.Scanner

if an input line is too long (more than bufio.MaxScanTokenSize), bufio.Scanner returns bufio.ErrToolong.

Use bufio's ReadString instead.

Fixes golang.org/go#57807

Change-Id: If4165213668a468b844ee6a0ae84263475504208
GitHub-Last-Rev: e7057d0
GitHub-Pull-Request: golang#423
Reviewed-on: https://go-review.googlesource.com/c/tools/+/462053
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
gopls-CI: kokoro <[email protected]>

Author: ukai

cmd/digraph/digraph.go

@@ -351,20 +351,29 @@ func parse(rd io.Reader) (graph, error) {
 	g := make(graph)
 
 	var linenum int
-	in := bufio.NewScanner(rd)
-	for in.Scan() {
+	// We avoid bufio.Scanner as it imposes a (configurable) limit
+	// on line length, whereas Reader.ReadString does not.
+	in := bufio.NewReader(rd)
+	for {
 		linenum++
+		line, err := in.ReadString('\n')
+		eof := false
+		if err == io.EOF {
+			eof = true
+		} else if err != nil {
+			return nil, err
+		}
 		// Split into words, honoring double-quotes per Go spec.
-		words, err := split(in.Text())
+		words, err := split(line)
 		if err != nil {
 			return nil, fmt.Errorf("at line %d: %v", linenum, err)
 		}
 		if len(words) > 0 {
 			g.addEdges(words[0], words[1:]...)
 		}
-	}
-	if err := in.Err(); err != nil {
-		return nil, err
+		if eof {
+			break
+		}
 	}
 	return g, nil
 }

cmd/digraph/digraph_test.go

@@ -45,6 +45,7 @@ e e
 		{"scss", g2, "sccs", nil, "c d\ne\n"},
 		{"scc", g2, "scc", []string{"d"}, "c\nd\n"},
 		{"succs", g2, "succs", []string{"a"}, "b\nc\n"},
+		{"succs-long-token", g2 + "x " + strings.Repeat("x", 96*1024), "succs", []string{"x"}, strings.Repeat("x", 96*1024) + "\n"},
 		{"preds", g2, "preds", []string{"c"}, "a\nd\n"},
 		{"preds multiple args", g2, "preds", []string{"c", "d"}, "a\nb\nc\nd\n"},
 	} {