fix: better memory cleanup

Author: niieani

src/v3/Trace.ts

@@ -1248,6 +1248,8 @@ export class Trace<
         transition.transitionToState === 'complete'
       ) {
         const traceRecording = createTraceRecording(
+          // we don't want to pass 'this' but select the relevant properties
+          // to avoid circular references
           {
             definition: this.definition,
             recordedItems: this.recordedItems,
@@ -1259,9 +1261,11 @@ export class Trace<
         this.onEnd(traceRecording)
 
         // memory clean-up in case something retains the Trace instance
-        this.recordedItems.clear()
-        this.occurrenceCounters.clear()
+        this.recordedItems = new Set()
+        this.occurrenceCounters = new Map()
         this.processedPerformanceEntries = new WeakMap()
+        // @ts-expect-error memory cleanup force override the otherwise readonly property
+        this.recordedItemsByLabel = {}
         this.traceUtilities.performanceEntryDeduplicationStrategy?.reset()
       }
     },

src/v3/recordingComputeUtils.test.ts

@@ -59,7 +59,11 @@ describe('recordingComputeUtils', () => {
           },
           recordedItemsByLabel: {},
         },
-        { transitionFromState: 'active' },
+        {
+          transitionFromState: 'active',
+          lastRelevantSpanAndAnnotation: undefined,
+          transitionToState: 'complete',
+        },
       )
 
       expect(recording.status).toBe('error')
@@ -92,7 +96,11 @@ describe('recordingComputeUtils', () => {
           },
           recordedItemsByLabel: {},
         },
-        { transitionFromState: 'active' },
+        {
+          transitionFromState: 'active',
+          lastRelevantSpanAndAnnotation: undefined,
+          transitionToState: 'complete',
+        },
       )
 
       expect(recording.status).toBe('ok')
@@ -127,7 +135,11 @@ describe('recordingComputeUtils', () => {
           },
           recordedItemsByLabel: {},
         },
-        { transitionFromState: 'active' },
+        {
+          transitionFromState: 'active',
+          lastRelevantSpanAndAnnotation: undefined,
+          transitionToState: 'complete',
+        },
       )
 
       expect(recording.status).toBe('error')

src/v3/recordingComputeUtils.ts

@@ -379,7 +379,6 @@ export function createTraceRecording<
 >(
   context: TraceContext<SelectedRelationNameT, RelationSchemasT, VariantsT>,
   {
-    transitionFromState,
     transitionToState,
     interruptionReason,
     cpuIdleSpanAndAnnotation,