Skip to content

feat: computedSpans -- allow to use matchingIndex #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 16, 2025

Conversation

xnanodax
Copy link
Contributor

@xnanodax xnanodax commented Apr 4, 2025

how this will be used

      // lastOfSpansFromTheList
      endSpan: {
        // matchIndex: -1,
        matchingRelations: true,
        isIdle: true,
        oneOf: [{ name: 'OmniLog' }, { name: 'ConversationPane' }],
      },

      endSpan: {
        matchIndex: -1,
        matcher: {
          oneOf: [
            {
              name: 'OmniLog',
              matchingRelations: true,
              isIdle: true,
            },
            {
              name: 'ConversationPane',
              matchingRelations: true,
              isIdle: true,
            },
          ],
        },
      },

@xnanodax xnanodax changed the title feat: create lastOfSpansFromTheList feat: computedSpans -- allow to use matchingIndex Apr 4, 2025
Base automatically changed from report-error-fns to next April 9, 2025 21:13
@bbrzoska bbrzoska requested a review from Copilot April 14, 2025 22:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/v3/recordingComputeUtils.ts:247

  • The identifier 'markedComplete' is used here but is not defined or imported in this file, which could lead to runtime errors. Please ensure that 'markedComplete' is properly defined or imported.
matchingEndEntry = findMatchingSpan(markedComplete, recordedItemsArray, context)

@bbrzoska bbrzoska merged commit 56db9b3 into next Apr 16, 2025
2 checks passed
@bbrzoska bbrzoska deleted the lastOfSpansFromTheList branch April 16, 2025 20:08
Copy link

🎉 This PR is included in version 2.4.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

bbrzoska pushed a commit that referenced this pull request May 13, 2025
Co-authored-by: Bazyli Brzoska <[email protected]>
Co-authored-by: Cynthia Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants