-
Notifications
You must be signed in to change notification settings - Fork 1
feat: computedSpans -- allow to use matchingIndex #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iming-hooks into report-error-fns # Conflicts: # src/v3/Trace.ts
Co-authored-by: Cynthia Ma <[email protected]>
fac558b
to
e7a6ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/v3/recordingComputeUtils.ts:247
- The identifier 'markedComplete' is used here but is not defined or imported in this file, which could lead to runtime errors. Please ensure that 'markedComplete' is properly defined or imported.
matchingEndEntry = findMatchingSpan(markedComplete, recordedItemsArray, context)
bbrzoska
reviewed
Apr 14, 2025
🎉 This PR is included in version 2.4.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bbrzoska
pushed a commit
that referenced
this pull request
May 13, 2025
Co-authored-by: Bazyli Brzoska <[email protected]> Co-authored-by: Cynthia Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how this will be used