From c0c77856a5016664b1386b2640053bfed72457cb Mon Sep 17 00:00:00 2001 From: elena Date: Mon, 27 Apr 2020 18:13:34 -0700 Subject: [PATCH 1/2] Issue 823 > Use max_wait_time while sleeping in fetch_batches --- .gitignore | 1 + lib/kafka/consumer.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 8ec7d4bba..f5779b489 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ /spec/reports/ /tmp/ .env +.idea/ *.log *.swp .byebug_history diff --git a/lib/kafka/consumer.rb b/lib/kafka/consumer.rb index b1c7d77f8..6768089a0 100644 --- a/lib/kafka/consumer.rb +++ b/lib/kafka/consumer.rb @@ -546,7 +546,7 @@ def fetch_batches if !@fetcher.data? @logger.debug "No batches to process" - sleep 2 + sleep(@fetcher.max_wait_time || 2) [] else tag, message = @fetcher.poll From 9ed5ecc4ebb9339fbef586417bd678f0c34ceecd Mon Sep 17 00:00:00 2001 From: elena Date: Mon, 27 Apr 2020 18:39:01 -0700 Subject: [PATCH 2/2] add max_wait_time to addr_reader for fetcher --- .gitignore | 1 - lib/kafka/fetcher.rb | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f5779b489..8ec7d4bba 100644 --- a/.gitignore +++ b/.gitignore @@ -8,7 +8,6 @@ /spec/reports/ /tmp/ .env -.idea/ *.log *.swp .byebug_history diff --git a/lib/kafka/fetcher.rb b/lib/kafka/fetcher.rb index 57d5a0bf7..cc423dd58 100644 --- a/lib/kafka/fetcher.rb +++ b/lib/kafka/fetcher.rb @@ -4,7 +4,7 @@ module Kafka class Fetcher - attr_reader :queue + attr_reader :queue, :max_wait_time def initialize(cluster:, logger:, instrumenter:, max_queue_size:, group:) @cluster = cluster