Refactoring code's style and user view header

Author: Gianluca Arbezzano

module/User/view/user/helper/new-users.phtml

@@ -10,7 +10,7 @@
                     <div class="col-md-12">
             <?php endif; ?>
                         <div class="col-md-3">
-                            <a href="<?php echo $this->url("modules-for-user", ["owner" => $user->getUserName()]); ?>" data-delay="0" rel="tooltip" title="<?php echo $this->escapeHtmlAttr($user->getUserName()); ?>" class="thumbnail">
+                            <a href="<?php echo $this->url('modules-for-user', ['owner' => $user->getUserName()]); ?>" data-delay="0" rel="tooltip" title="<?php echo $this->escapeHtmlAttr($user->getUserName()); ?>" class="thumbnail">
                                 <img src="<?php echo $this->escapeHtmlAttr($user->getPhotoUrl()) ?>" alt="<?php echo $this->escapeHtmlAttr($user->getUsername()) ?>" class="img-responsive">
                             </a>
                         </div>

module/ZfModule/src/ZfModule/Controller/UserController.php

@@ -15,25 +15,23 @@ class UserController extends AbstractActionController
     /**
      * @param Mapper\Module $moduleMapper
      */
-    public function __construct(
-        Mapper\Module $moduleMapper
-    ) {
+    public function __construct(Mapper\Module $moduleMapper)
+    {
         $this->moduleMapper = $moduleMapper;
     }
 
     public function modulesForUserAction()
     {
-        $query =  $this->params()->fromQuery('query', null);
-        $page = (int) $this->params()->fromQuery('page', 1);
-        $owner = $this->params()->fromRoute('owner');
+        $params = $this->params();
+        $query =  $params->fromQuery('query', null);
+        $page = (int) $params->fromQuery('page', 1);
+        $owner = $params->fromRoute('owner');
 
-        $modules = $this->moduleMapper->pagination($page, 10, $owner, 'created_at', "DESC");
+        $modules = $this->moduleMapper->pagination($page, 10, $owner, 'created_at', 'DESC');
 
-        $viewModel = new ViewModel([
+        return new ViewModel([
             'modules' => $modules,
             'query' => $query,
-         ]);
-
-        return $viewModel;
+        ]);
     }
 }

module/ZfModule/test/ZfModuleTest/Integration/Controller/UserControllerTest.php

@@ -0,0 +1,50 @@
+<?php
+
+namespace ZfModuleTest\Integration\Controller;
+
+use ApplicationTest\Integration\Util\Bootstrap;
+use Zend\Paginator;
+use Zend\Test\PHPUnit\Controller\AbstractHttpControllerTestCase;
+use ZfModule\Controller;
+use ZfModule\Mapper;
+
+class UserControllerTest extends AbstractHttpControllerTestCase
+{
+    protected function setUp()
+    {
+        parent::setUp();
+
+        $this->setApplicationConfig(Bootstrap::getConfig());
+    }
+
+    public function testUserPageCanBeAccessed()
+    {
+        $moduleMapper = $this->getMockBuilder(Mapper\Module::class)->getMock();
+
+        $moduleMapper
+            ->expects($this->once())
+            ->method('pagination')
+            ->with(
+                $this->equalTo(1),
+                $this->equalTo(10),
+                $this->equalTo("gianarb"),
+                $this->equalTo('created_at'),
+                $this->equalTo('DESC')
+            )
+            ->willReturn(new Paginator\Paginator(new Paginator\Adapter\Null()))
+        ;
+
+        $this->getApplicationServiceLocator()
+            ->setAllowOverride(true)
+            ->setService(
+                Mapper\Module::class,
+                $moduleMapper
+            )
+        ;
+
+        $this->dispatch('/user/gianarb');
+
+        $this->assertControllerName(Controller\UserController::class);
+        $this->assertActionName('modulesForUser');
+    }
+}

module/ZfModule/view/zf-module/index/view.phtml

@@ -1,7 +1,7 @@
 <?php $this->headTitle($this->escapeHtmlAttr($module) . ' module by ' . $this->escapeHtmlAttr($vendor)); ?>
 <?php $this->headMeta()->appendName('description', $this->escapeHtmlAttr($repository->description)); ?>
 
-<h3><a href="<?php echo $this->url("modules-for-user", ["owner" => $vendor]); ?>"><?php echo $this->escapeHtml($vendor); ?></a> / <?php echo $this->escapeHtml($module); ?> </h3>
+<h3><a href="<?php echo $this->url('modules-for-user', ['owner' => $vendor]); ?>"><?php echo $this->escapeHtml($vendor); ?></a> / <?php echo $this->escapeHtml($module); ?> </h3>
 
 <div class="row">
     <div class="col-md-8">

module/ZfModule/view/zf-module/user/modules-for-user.phtml

@@ -1,4 +1,4 @@
-<?php $this->layout()->withLargeHeader = true; ?>
+<?php $this->layout()->withLargeHeader = false; ?>
 
 <div class="col-xs-12 col-md-8">
     <?php if (count($this->modules) >= 1): ?>