Swap yoda conditions

We tend not to use yoda comaprision as there are less readable

Author: michalbundyra

src/Pattern/PatternOptions.php

@@ -152,7 +152,7 @@ class PatternOptions extends AbstractOptions
     public function __construct($options = null)
     {
         // disable file/directory permissions by default on windows systems
-        if (0 === stripos(PHP_OS, 'WIN')) {
+        if (stripos(PHP_OS, 'WIN') === 0) {
             $this->filePermission = false;
             $this->dirPermission = false;
         }

src/Storage/Adapter/Dba.php

@@ -229,7 +229,7 @@ public function clearByNamespace($namespace)
             $recheck     = false;
             $internalKey = dba_firstkey($this->handle);
             while ($internalKey !== false && $internalKey !== null) {
-                if (0 === strpos($internalKey, $prefix)) {
+                if (strpos($internalKey, $prefix) === 0) {
                     $result = dba_delete($internalKey, $this->handle) && $result;
                 }
 
@@ -267,7 +267,7 @@ public function clearByPrefix($prefix)
             $recheck     = false;
             $internalKey = dba_firstkey($this->handle);
             while ($internalKey !== false && $internalKey !== null) {
-                if (0 === strpos($internalKey, $prefix)) {
+                if (strpos($internalKey, $prefix) === 0) {
                     $result = dba_delete($internalKey, $this->handle) && $result;
                     $recheck = true;
                 }

src/Storage/Adapter/FilesystemOptions.php

@@ -119,7 +119,7 @@ class FilesystemOptions extends AdapterOptions
     public function __construct($options = null)
     {
         // disable file/directory permissions by default on windows systems
-        if (0 === stripos(PHP_OS, 'WIN')) {
+        if (stripos(PHP_OS, 'WIN') === 0) {
             $this->filePermission = false;
             $this->dirPermission = false;
         }

src/Storage/Adapter/MemcachedResourceManager.php

@@ -332,7 +332,7 @@ public function getLibOptions($id)
             $reflection = new ReflectionClass('Memcached');
             $constants  = $reflection->getConstants();
             foreach ($constants as $constName => $constValue) {
-                if (0 === strpos($constName, 'OPT_')) {
+                if (strpos($constName, 'OPT_') === 0) {
                     $libOptions[$constValue] = $resource->getOption($constValue);
                 }
             }

src/Storage/Adapter/Memory.php

@@ -205,7 +205,7 @@ public function clearByPrefix($prefix)
 
         $data    = & $this->data[$ns];
         foreach ($data as $key => & $item) {
-            if (0 === strpos($key, $prefix)) {
+            if (strpos($key, $prefix) === 0) {
                 unset($data[$key]);
             }
         }

src/Storage/Adapter/RedisResourceManager.php

@@ -492,7 +492,7 @@ public function getLibOptions($id)
             $reflection = new ReflectionClass('Redis');
             $constants  = $reflection->getConstants();
             foreach ($constants as $constName => $constValue) {
-                if (0 === strpos($constName, 'OPT_')) {
+                if (strpos($constName, 'OPT_') === 0) {
                     $libOptions[$constValue] = $resource['resource']->getOption($constValue);
                 }
             }

src/Storage/Adapter/Session.php

@@ -124,7 +124,7 @@ public function clearByPrefix($prefix)
 
         $data    = $cntr->offsetGet($ns);
         foreach ($data as $key => & $item) {
-            if (0 === strpos($key, $prefix)) {
+            if (strpos($key, $prefix) === 0) {
                 unset($data[$key]);
             }
         }