Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 76f4f4c

Browse files
committed
#95 simplified test case, since we can now rely on PHP 5.5's ::class pseudo-constant
1 parent 9569e50 commit 76f4f4c

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

test/Generator/ParameterGeneratorTest.php

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212
use Zend\Code\Generator\ParameterGenerator;
1313
use Zend\Code\Generator\ValueGenerator;
14+
use Zend\Code\Reflection\MethodReflection;
1415
use Zend\Code\Reflection\ParameterReflection;
16+
use ZendTest\Code\Generator\TestAsset\ParameterClass;
1517
use ZendTest\Code\TestAsset\ClassTypeHintedClass;
1618
use ZendTest\Code\TestAsset\DocBlockOnlyHintsClass;
1719
use ZendTest\Code\TestAsset\InternalHintsClass;
@@ -98,17 +100,18 @@ public function testFromReflectionGetDefaultValue()
98100
$this->assertEquals('\'foo\'', (string) $defaultValue);
99101
}
100102

103+
/**
104+
* @group 95
105+
*/
101106
public function testFromReflectionGetDefaultValueNotOptional()
102107
{
103-
$reflectionClass = new \Zend\Code\Reflection\ClassReflection(
104-
'ZendTest\Code\Generator\TestAsset\ParameterClass'
105-
);
106-
$method = $reflectionClass->getMethod('defaultObjectEqualsNullAndNotOptional');
108+
$method = new MethodReflection(ParameterClass::class, 'defaultObjectEqualsNullAndNotOptional');
107109

108110
$params = $method->getParameters();
111+
109112
$this->assertCount(2, $params);
110113

111-
$firstParameter = $codeGenParam = ParameterGenerator::fromReflection($params[0]);
114+
$firstParameter = ParameterGenerator::fromReflection($params[0]);
112115
$this->assertInstanceOf(ValueGenerator::class, $firstParameter->getDefaultValue());
113116
$this->assertNull($firstParameter->getDefaultValue()->getSourceContent());
114117
}

0 commit comments

Comments
 (0)