Skip to content

Commit 1b4b773

Browse files
authored
refactor: Update functions after prototype changes (#18)
MariaDB/server@21809f9 changes the following function prototypes: * tmp_use_all_columns, dbug_tmp_use_all_columns to accept MY_BITMAP** and to return MY_BITMAP * instead of my_bitmap_map* * tmp_restore_column_map, dbug_tmp_restore_column_maps to accept MY_BITMAP* instead of my_bitmap_map*
1 parent 4c1a4a8 commit 1b4b773

File tree

2 files changed

+44
-12
lines changed

2 files changed

+44
-12
lines changed

db2i_conversion.cc

+10-2
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,11 @@ static void get_field_default_value(Field *field,
241241
defaultClause.append(" DEFAULT ");
242242
if (!field->is_null())
243243
{
244-
my_bitmap_map *old_map = tmp_use_all_columns(field->table, field->table->read_set);
244+
#if MYSQL_VERSION_ID >= 100328
245+
MY_BITMAP *old_map = tmp_use_all_columns(field->table, &field->table->read_set);
246+
#else
247+
my_bitmap_map *old_map = tmp_use_all_columns(field->table, field->table->read_set);
248+
#endif
245249
char tmp[MAX_FIELD_WIDTH];
246250

247251
if (field->real_type() == MYSQL_TYPE_ENUM ||
@@ -373,7 +377,11 @@ static void get_field_default_value(Field *field,
373377
else
374378
defaultClause.length(0);
375379
}
376-
tmp_restore_column_map(field->table->read_set, old_map);
380+
#if MYSQL_VERSION_ID >= 100328
381+
tmp_restore_column_map(&field->table->read_set, old_map);
382+
#else
383+
tmp_restore_column_map(field->table->read_set, old_map);
384+
#endif
377385
}
378386
else if (field->maybe_null())
379387
defaultClause.append(STRING_WITH_LEN("NULL"));

ha_ibmdb2i.cc

+34-10
Original file line numberDiff line numberDiff line change
@@ -849,8 +849,11 @@ int ha_ibmdb2i::prepareRowForWrite(char* data, char* nulls, bool honorIdentCols)
849849
default_identity_value = FALSE;
850850

851851
ulong sql_mode = ha_thd()->variables.sql_mode;
852-
853-
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
852+
#if MYSQL_VERSION_ID >= 100328
853+
MY_BITMAP *old_map= dbug_tmp_use_all_columns(table, &table->read_set);
854+
#else
855+
my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->read_set);
856+
#endif
854857
for (Field **field = table->field; *field && !rc; ++field)
855858
{
856859
int fieldIndex = (*field)->field_index;
@@ -888,8 +891,11 @@ int ha_ibmdb2i::prepareRowForWrite(char* data, char* nulls, bool honorIdentCols)
888891
if (!rc && db2Table->hasBlobs())
889892
rc = db2i_ileBridge::getBridgeForThread()->objectOverride(activeHandle,
890893
activeWriteBuf->ptr());
891-
892-
dbug_tmp_restore_column_map(table->read_set, old_map);
894+
#if MYSQL_VERSION_ID >= 100328
895+
dbug_tmp_restore_column_map(&table->read_set, old_map);
896+
#else
897+
dbug_tmp_restore_column_map(table->read_set, old_map);
898+
#endif
893899

894900
return rc;
895901
}
@@ -1289,12 +1295,21 @@ int ha_ibmdb2i::rnd_end()
12891295
int32 ha_ibmdb2i::mungeDB2row(uchar* record, const char* dataPtr, const char* nullMapPtr, bool skipLOBs)
12901296
{
12911297
DBUG_ASSERT(dataPtr);
1292-
1298+
#if MYSQL_VERSION_ID >= 100328
1299+
MY_BITMAP *old_write_map= dbug_tmp_use_all_columns(table, &table->write_set);
1300+
MY_BITMAP *old_read_map;
1301+
#else
12931302
my_bitmap_map *old_write_map= dbug_tmp_use_all_columns(table, table->write_set);
12941303
my_bitmap_map *old_read_map;
1304+
#endif
12951305

1296-
if (unlikely(readAllColumns))
1297-
old_read_map = tmp_use_all_columns(table, table->read_set);
1306+
if (unlikely(readAllColumns)){
1307+
#if MYSQL_VERSION_ID >= 100328
1308+
old_read_map = tmp_use_all_columns(table, &table->read_set);
1309+
#else
1310+
old_read_map = tmp_use_all_columns(table, table->read_set);
1311+
#endif
1312+
}
12981313

12991314
resetCharacterConversionBuffers();
13001315

@@ -1320,9 +1335,18 @@ int32 ha_ibmdb2i::mungeDB2row(uchar* record, const char* dataPtr, const char* nu
13201335

13211336
}
13221337

1323-
if (unlikely(readAllColumns))
1324-
tmp_restore_column_map(table->read_set, old_read_map);
1325-
dbug_tmp_restore_column_map(table->write_set, old_write_map);
1338+
if (unlikely(readAllColumns)) {
1339+
#if MYSQL_VERSION_ID >= 100328
1340+
tmp_restore_column_map(&table->read_set, old_read_map);
1341+
#else
1342+
tmp_restore_column_map(table->read_set, old_read_map);
1343+
#endif
1344+
}
1345+
#if MYSQL_VERSION_ID >= 100328
1346+
dbug_tmp_restore_column_map(&table->write_set, old_write_map);
1347+
#else
1348+
dbug_tmp_restore_column_map(table->write_set, old_write_map);
1349+
#endif
13261350

13271351
return 0;
13281352
}

0 commit comments

Comments
 (0)