shell: fix coverity issue

Jakub Rzeszutko · nashif · commit 4fb20c40a18e · 2019-03-04T09:41:13.000-05:00
Fixing a case where variable could be used without an initialization.

Signed-off-by: Jakub Rzeszutko &lt;jakub.rzeszutko@nordicsemi.no&gt;
diff --git a/subsys/shell/shell.c b/subsys/shell/shell.c
@@ -608,6 +608,9 @@ static int execute(const struct shell *shell)
 		return -ENOEXEC;
 	}
 
+	/* Initialize help variable */
+	help_entry.help = NULL;
+
 	/* Below loop is analyzing subcommands of found root command. */
 	while (true) {
 		if (cmd_lvl >= argc) {

Original file line number	Diff line number	Diff line change
`@@ -608,6 +608,9 @@ static int execute(const struct shell *shell)`
`608`	`608`	`return -ENOEXEC;`
`609`	`609`	`}`
`610`	`610`
	`611`	`+ /* Initialize help variable */`
	`612`	`+ help_entry.help = NULL;`
	`613`	`+`
`611`	`614`	`/* Below loop is analyzing subcommands of found root command. */`
`612`	`615`	`while (true) {`
`613`	`616`	`if (cmd_lvl >= argc) {`