net: virtual: Fix compiler warnings related to interface name

clamattia · kartben · commit 72fcca03045b · 2025-03-27T21:33:40.000+01:00
Fix compiler warning by adjusting the number of chars copied to the
destination. Compiler does not like if the destination size of the
`strncpy`-operation is the same as the number of characters written. Even
though it is not a bug in this case. Only copying size-1 characters fixes
the warning and exhibits the same behavior.

Signed-off-by: Cla Mattia Galliard &lt;cla-mattia.galliard@zuehlke.com&gt;
diff --git a/subsys/net/l2/virtual/virtual.c b/subsys/net/l2/virtual/virtual.c
@@ -388,8 +388,8 @@ void net_virtual_set_name(struct net_if *iface, const char *name)
 
 	ctx = net_if_l2_data(iface);
 
-	strncpy(ctx->name, name, CONFIG_NET_L2_VIRTUAL_MAX_NAME_LEN);
-	ctx->name[CONFIG_NET_L2_VIRTUAL_MAX_NAME_LEN - 1] = '\0';
+	strncpy(ctx->name, name, ARRAY_SIZE(ctx->name) - 1);
+	ctx->name[ARRAY_SIZE(ctx->name) - 1] = '\0';
 }
 
 enum net_l2_flags net_virtual_set_flags(struct net_if *iface,

Original file line number	Diff line number	Diff line change
`@@ -388,8 +388,8 @@ void net_virtual_set_name(struct net_if iface, const char name)`
`388`	`388`
`389`	`389`	`ctx = net_if_l2_data(iface);`
`390`	`390`
`391`		`- strncpy(ctx->name, name, CONFIG_NET_L2_VIRTUAL_MAX_NAME_LEN);`
`392`		`- ctx->name[CONFIG_NET_L2_VIRTUAL_MAX_NAME_LEN - 1] = '\0';`
	`391`	`+ strncpy(ctx->name, name, ARRAY_SIZE(ctx->name) - 1);`
	`392`	`+ ctx->name[ARRAY_SIZE(ctx->name) - 1] = '\0';`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`enum net_l2_flags net_virtual_set_flags(struct net_if *iface,`