Skip to content

Commit 8905b0f

Browse files
Charles E. Yousenashif
Charles E. Youse
authored andcommitted
drivers/gpio_intel_apl.c: fix return value for gpio_pin_read()
gpio_intel_apl_read() should set *value to 1, not 2, when the GPIO input is a logical high. Fixes: #15499 Signed-off-by: Charles E. Youse <[email protected]>
1 parent 6b4007e commit 8905b0f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpio/gpio_intel_apl.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -345,10 +345,10 @@ static int gpio_intel_apl_read(struct device *dev, int access_op,
345345

346346
if (!(val & PAD_CFG0_TXDIS)) {
347347
/* If TX is not disabled, return TX_STATE */
348-
*value = val & PAD_CFG0_TXSTATE;
348+
*value = (val & PAD_CFG0_TXSTATE) >> PAD_CFG0_TXSTATE_POS;
349349
} else {
350350
/* else just return RX_STATE */
351-
*value = val & PAD_CFG0_RXSTATE;
351+
*value = (val & PAD_CFG0_RXSTATE) >> PAD_CFG0_RXSTATE_POS;
352352
}
353353

354354
return 0;

0 commit comments

Comments
 (0)