Skip to content

ci: 'MIT' license verification fail on permissive license #11671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
b0661 opened this issue Nov 27, 2018 · 3 comments
Closed

ci: 'MIT' license verification fail on permissive license #11671

b0661 opened this issue Nov 27, 2018 · 3 comments
Assignees
Labels
Licensing The PR has licensing issues => licensing expert to review

Comments

@b0661
Copy link
Collaborator

b0661 commented Nov 27, 2018

Describe the bug

PR #10885 contains files that are licensed "mit" ( see https://spdx.org/licenses/MIT.html). This is a much more permissive license than apache-2.0. It should not make CI fail.

To Reproduce

Add a file wirh "SPDX-License-Identifier: mit" and run CI.

Expected behavior

CI license verification shall pass on "SPDX-License-Identifier: mit".

Impact

CI of PR #10885, #10888 declared failed.

Screenshots or console output

PR #10885

Environment (please complete the following information):

Zephyr CI

Additional context

@carlescufi carlescufi added the Licensing The PR has licensing issues => licensing expert to review label Nov 27, 2018
@nashif
Copy link
Member

nashif commented Dec 8, 2018

Any file going into the zephyr tree with a different license that the project license needs to be reviewed. This check in CI is currently not 'required' for merging and still under heavy development, so a maintainer can override this check after reviewing the warnings and determining that the files are ok.

Will add some text explaining the above in the comment posted by CI.

@b0661
Copy link
Collaborator Author

b0661 commented Dec 9, 2018

Reviewers usually do not review until the CI status is "passed".

Can this become a hint for reviewers and CI set to "passed"?

@nashif
Copy link
Member

nashif commented Jan 8, 2019

We now add more information about the license scan, any license warning need to be reviewed and processed by someone, making them PASS is just going to be misleading. Those who merge can always override the check. My concern is that if we make it PASS, nobody will look at the warnings of non APL licensed files we are pulling into the tree.

@nashif nashif closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Licensing The PR has licensing issues => licensing expert to review
Projects
None yet
Development

No branches or pull requests

3 participants