-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Fix rounding in _ms_to_ticks() #12509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's one place where things get rounded down. The same truncation happens in |
@pizi-nordic @carlescufi is this still applicable, and if so, how can we address it ifor 2.0? |
IMHO it should be fixed. I can prepare PR after I finish userspace logging. |
Could you please address this for 2.0 @pizi-nordic ? |
@pizi-nordic |
@carlescufi: Yes, it will be fixed in #17155. However I will prepare a PR with this because #17155 will not go into 2.0 and now the requested change is safe as #16782 is merged. |
This is pending in #19591 which uses ceil for ms_to_ticks. |
At the moment the _ms_to_ticks() rounds down, which results in premature expiration of timeouts scheduled just before edge of tick. To fix that we have to revert #9745 in order to restore rounding up.
The text was updated successfully, but these errors were encountered: