-
Notifications
You must be signed in to change notification settings - Fork 7.4k
Websocket Server API #25395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The GPL2 license is not compatible with Apache2 license so MinnowServer cannot be used in Zephyr. |
Thank you for your message. Can you change then this Issue to feature request? |
@jukkar There were already sample implementation of Websocket Server in v1.13.0. Why is this sample no more in newer versions of Zephyr? |
The one in v1.13 was using net_app API which was removed in v1.14. This also meant that the applications using that API were also removed. One of those apps was websocket server. We could create a server sample app for websocket using BSD sockets, but no one has so far volunteered to do it. |
Thank you for very fast and good answer. I am interested in writing this implementation or rewriting the older one sample. I'll try provide a link to my PR later. |
@jukkar Does latest version ( v2.3.99 ) of zephyr has http server/client API? |
No, we have only client APIs in upstream Zephyr. There is the civetweb module that can be used when server side APIs are needed. There is a sample in |
I did not do the civetweb porting and I have not used the API so cannot confirm what you are asking. But the original idea of the civetweb porting was that it could be used in Zephyr as is, so I would expect it to work like you describe above. |
Can be solved by this |
IMHO having a native zephyr API is always a better than using external modules. That allows us to better optimize the code usage for zephyr. But if there are no resources to develop/maintain such APIs, good option is to use already existing external code. |
WHAT
Implementation of Websocket Server API would be helpful for embedded devices, which can be configured/controlled over Ethernet.
WHY
To such devices may belong Ethernet connected sound boxes, embedded routers or modems, toys, smart watches etc. Websocket Server API would allow configuration of such devices just right in your local network.
CURRENT SITUATION
Currently Zephyr has only Websocket Client API implementation.
SUGGESTED SOLUTION
We may adapt MinnowServer since it is under GPL2 License
Or implement it same way as MinnowServer.
Any suggestions?
The text was updated successfully, but these errors were encountered: