Skip to content

github integration: ensure maintainers are added to PRs that affect them #29199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pabigot opened this issue Oct 14, 2020 · 6 comments
Closed
Assignees
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@pabigot
Copy link
Collaborator

pabigot commented Oct 14, 2020

I'm maintainer of I2C, but there are things getting automatically labeled as I2C that I'm not being notified of.

Perhaps maintainers aren't supposed to be notified of anything that affects their area, but I would certainly like to know about changes to what I'm nominally responsible for. If the label can be added, I'd expect the reviewer/assignee could be as well.

@pabigot pabigot added the Enhancement Changes/Updates/Additions to existing features label Oct 14, 2020
@galak
Copy link
Collaborator

galak commented Oct 14, 2020

When you say things, I assume you mean PRs. Right now the only way people get added is via CODEOWNERs, so its possible that CODEOWNERS and .github/labeler.yml are out of sync.

@pabigot
Copy link
Collaborator Author

pabigot commented Oct 14, 2020

Or that there's a disconnect between being a maintainer and being a code-owner. There are 11 CODEOWNERS entries that are covered by the I2C MAINTAINERS patterns (and one that isn't, but should be).

I don't think I should have to add myself to every CODEOWNERS line involving I2C, and monitor that file for cases where it gets out of sync again.

@carlescufi
Copy link
Member

Unfortunately this is a consequence of using multiple mechanisms for maintainership tracking. We can switch from CODEOWNERS, which is automatically handled by GitHub, to a custom workflow that assigns maintainers based on the MAINTAINERS file, but AFAIK this is not being worked on yet. @nashif or @ioannisg do you know if we have plans for such a workflow?

@stephanosio
Copy link
Member

Fixed by #38725:

Maintainers are now added as an assignee on the relevant PRs.

@pabigot
Copy link
Collaborator Author

pabigot commented May 23, 2022

Fixed by #38725:

Maintainers are now added as an assignee on the relevant PRs.

How is it appropriate to close this issue as fixed, given that #38725 is open and on hold, and #45865 identifies more problems with the solution that is implemented?

Don't feel obliged to answer on my behalf. 🤦

@stephanosio
Copy link
Member

#38725 has already been implemented and is currently functional as noted above.
#45865 has nothing to do with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

5 participants