-
Notifications
You must be signed in to change notification settings - Fork 7.3k
github integration: ensure maintainers are added to PRs that affect them #29199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
When you say things, I assume you mean PRs. Right now the only way people get added is via CODEOWNERs, so its possible that CODEOWNERS and .github/labeler.yml are out of sync. |
Or that there's a disconnect between being a maintainer and being a code-owner. There are 11 I don't think I should have to add myself to every |
Unfortunately this is a consequence of using multiple mechanisms for maintainership tracking. We can switch from |
Fixed by #38725: Maintainers are now added as an assignee on the relevant PRs. |
I'm maintainer of I2C, but there are things getting automatically labeled as I2C that I'm not being notified of.
Perhaps maintainers aren't supposed to be notified of anything that affects their area, but I would certainly like to know about changes to what I'm nominally responsible for. If the label can be added, I'd expect the reviewer/assignee could be as well.
The text was updated successfully, but these errors were encountered: