Skip to content

Clean up timeout handling #9627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyross opened this issue Aug 25, 2018 · 2 comments
Closed

Clean up timeout handling #9627

andyross opened this issue Aug 25, 2018 · 2 comments
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@andyross
Copy link
Collaborator

See discussion in #9620 and #8669

The handle_expired_timeouts() mechanism is fragile. The specific bug was patched, but the code is too large and complicated for what it does (trying to build a list of expired timeouts ahead of time before invoking them instead of just doing a while loop on the queue with simpler constraints).

It also needs some work to unify the tickless handling with the normal timeout stuff, which is needlessly divergent.

@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Aug 27, 2018
@findlayfeng
Copy link
Contributor

Here you need to keep next.
Because the current timeout will destroy the pointer to next if it is re-added, continuing to follow the next loop will have unpredictable results.
Just need to remove remove

@andyross
Copy link
Collaborator Author

Timeouts got reworked in the timer rewrite. Closing my own bug, because obviously I think my new implementation is better than the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

3 participants