avoid changing shardstate reads list during iteration (ydb-platform#12150)

ssmike · zinal · commit 502e29962108 · 2024-11-29T23:19:40.000+03:00
diff --git a/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp b/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp
@@ -397,12 +397,16 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku
         auto shardIt = ReadsPerShard.find(tabletId);
         YQL_ENSURE(shardIt != ReadsPerShard.end());
 
+        TVector<TReadState*> toRetry;
         for (auto* read : shardIt->second.Reads) {
             if (read->State == EReadState::Running) {
                 Counters->IteratorDeliveryProblems->Inc();
-                RetryTableRead(*read);
+                toRetry.push_back(read);
             }
         }
+        for (auto* read : toRetry) {
+            RetryTableRead(*read);
+        }
     }
 
     void Handle(TEvPrivate::TEvSchemeCacheRequestTimeout::TPtr&) {

Original file line number	Diff line number	Diff line change
`@@ -397,12 +397,16 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku`
`397`	`397`	`auto shardIt = ReadsPerShard.find(tabletId);`
`398`	`398`	`YQL_ENSURE(shardIt != ReadsPerShard.end());`
`399`	`399`
	`400`	`+ TVector<TReadState*> toRetry;`
`400`	`401`	`for (auto* read : shardIt->second.Reads) {`
`401`	`402`	`if (read->State == EReadState::Running) {`
`402`	`403`	`Counters->IteratorDeliveryProblems->Inc();`
`403`		`- RetryTableRead(*read);`
	`404`	`+ toRetry.push_back(read);`
`404`	`405`	`}`
`405`	`406`	`}`
	`407`	`+ for (auto* read : toRetry) {`
	`408`	`+ RetryTableRead(*read);`
	`409`	`+ }`
`406`	`410`	`}`
`407`	`411`
`408`	`412`	`void Handle(TEvPrivate::TEvSchemeCacheRequestTimeout::TPtr&) {`