workaround a V8 AsyncDisposableStack bug

tc39/proposal-explicit-resource-management#256

Author: zloirock

CHANGELOG.md

@@ -18,8 +18,9 @@
   - Extracted from [old `Math` extensions proposal](https://github.com/rwaldron/proposal-math-extensions), [February 2025 TC39 meeting](https://github.com/tc39/proposals/commit/0c24594aab19a50b86d0db7248cac5eb0ae35621)
   - Added arguments validation
   - Added new entries
+- Added a workaround of a V8 `AsyncDisposableStack` bug, [tc39/proposal-explicit-resource-management/256](https://github.com/tc39/proposal-explicit-resource-management/issues/256)
 - Compat data improvements:
-  - [`DisposableStack`, `AsyncDisposableStack`, `SuppressedError` and `Iterator.prototype[@@dispose]`](https://github.com/tc39/proposal-explicit-resource-management) marked as [shipped from V8 ~ Chromium 134](https://issues.chromium.org/issues/42203506#comment24)
+  - [`DisposableStack`, `SuppressedError` and `Iterator.prototype[@@dispose]`](https://github.com/tc39/proposal-explicit-resource-management) marked as [shipped from V8 ~ Chromium 134](https://issues.chromium.org/issues/42203506#comment24)
   - [`Error.isError`](https://github.com/tc39/proposal-is-error) added and marked as [shipped from V8 ~ Chromium 134](https://issues.chromium.org/issues/382104870#comment4)
   - [`Math.f16round` and `DataView.prototype.{ getFloat16, setFloat16 }`](https://github.com/tc39/proposal-float16array) marked as [shipped from V8 ~ Chromium 135](https://issues.chromium.org/issues/42203953#comment36)
   - [`Iterator` helpers proposal](https://github.com/tc39/proposal-iterator-helpers) features marked as [shipped from Safari 18.4](https://developer.apple.com/documentation/safari-release-notes/safari-18_4-release-notes#New-Features)

packages/core-js-compat/src/data.mjs

@@ -2287,8 +2287,9 @@ export const data = {
   // TODO: Remove from `core-js@4`
   'esnext.array-buffer.transfer-to-fixed-length': null,
   'esnext.async-disposable-stack.constructor': {
-    // reverted in https://issues.chromium.org/issues/42203506#comment25
-    chrome: '134', // '133',
+    // added in 133, reverted in 134, https://issues.chromium.org/issues/42203506#comment25
+    // https://github.com/tc39/proposal-explicit-resource-management/issues/256, fixed in early 135
+    chrome: '136',
     deno: false,
   },
   'esnext.async-iterator.constructor': {

packages/core-js/modules/esnext.async-disposable-stack.constructor.js

@@ -11,6 +11,7 @@ var defineBuiltInAccessor = require('../internals/define-built-in-accessor');
 var wellKnownSymbol = require('../internals/well-known-symbol');
 var InternalStateModule = require('../internals/internal-state');
 var addDisposableResource = require('../internals/add-disposable-resource');
+var V8_VERSION = require('../internals/environment-v8-version');
 
 var Promise = getBuiltIn('Promise');
 var SuppressedError = getBuiltIn('SuppressedError');
@@ -125,6 +126,10 @@ if (DESCRIPTORS) defineBuiltInAccessor(AsyncDisposableStackPrototype, 'disposed'
 defineBuiltIn(AsyncDisposableStackPrototype, ASYNC_DISPOSE, AsyncDisposableStackPrototype.disposeAsync, { name: 'disposeAsync' });
 defineBuiltIn(AsyncDisposableStackPrototype, TO_STRING_TAG, ASYNC_DISPOSABLE_STACK, { nonWritable: true });
 
-$({ global: true, constructor: true }, {
+// https://github.com/tc39/proposal-explicit-resource-management/issues/256
+// can't be detected synchronously
+var SYNC_DISPOSE_RETURNING_PROMISE_RESOLUTION_BUG = V8_VERSION && V8_VERSION < 136;
+
+$({ global: true, constructor: true, forced: SYNC_DISPOSE_RETURNING_PROMISE_RESOLUTION_BUG }, {
   AsyncDisposableStack: $AsyncDisposableStack
 });

tests/compat/tests.js

@@ -1653,6 +1653,9 @@ GLOBAL.tests = {
     return [].uniqueBy;
   },
   'esnext.async-disposable-stack.constructor': function () {
+    // https://github.com/tc39/proposal-explicit-resource-management/issues/256
+    // can't be detected synchronously
+    if (V8_VERSION && V8_VERSION < 136) return;
     return typeof AsyncDisposableStack == 'function';
   },
   'esnext.async-iterator.constructor': function () {

tests/unit-global/esnext.async-disposable-stack.constructor.js

@@ -184,3 +184,19 @@ QUnit.test('AsyncDisposableStack#3', assert => {
     assert.same(error.suppressed.message, '3');
   });
 });
+
+// https://github.com/tc39/proposal-explicit-resource-management/issues/256
+QUnit.test('AsyncDisposableStack#256', assert => {
+  const resume = assert.async();
+  assert.expect(1);
+  let called = false;
+  const stack = new AsyncDisposableStack();
+  const neverResolves = new Promise(() => { /* empty */ });
+  stack.use({ [Symbol.dispose]() { return neverResolves; } });
+  stack.disposeAsync().then(() => {
+    called = true;
+    assert.required('It should be called');
+    resume();
+  });
+  setTimeout(() => called || resume(), 3e3);
+});

tests/unit-pure/esnext.async-disposable-stack.constructor.js

@@ -184,3 +184,19 @@ QUnit.test('AsyncDisposableStack#3', assert => {
     assert.same(error.suppressed.message, '3');
   });
 });
+
+// https://github.com/tc39/proposal-explicit-resource-management/issues/256
+QUnit.test('AsyncDisposableStack#256', assert => {
+  const resume = assert.async();
+  assert.expect(1);
+  let called = false;
+  const stack = new AsyncDisposableStack();
+  const neverResolves = new Promise(() => { /* empty */ });
+  stack.use({ [Symbol.dispose]() { return neverResolves; } });
+  stack.disposeAsync().then(() => {
+    called = true;
+    assert.required('It should be called');
+    resume();
+  });
+  setTimeout(() => called || resume(), 3e3);
+});