Skip to content

validation breaks if x5c array is empty #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Nov 4, 2021 · 2 comments
Closed

validation breaks if x5c array is empty #406

ghost opened this issue Nov 4, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 4, 2021

if jwk.x5c then

Could we get and #jwk.x5c > 0 added here? Token validation breaks if the array is empty and it's referenced as a TODO in two spots.
It doesn't look like public contributions are enabled on this repo..

@bodewig
Copy link
Collaborator

bodewig commented Nov 6, 2021

My interpretation of RFC 7517 is the x5c array must contain at least one element for the JWKS to be valid. The claim itself is optional but to me an empty array is different from a claim not being present. I'd recommend you contact your vendor.

At least I don't recall putting in the TODOs. :-)

Of course we could make the parser more lenient, issue a warning here and treat the JWK as if the x5c claim was missing.

Not sure what you mean with "public contributions enabled". Obviously it is possible to create issues and pull requests are supported as well. Is there anything specific you are missing?

@bodewig bodewig closed this as completed in d52fc6c Nov 6, 2021
@bodewig
Copy link
Collaborator

bodewig commented Nov 6, 2021

fixed in master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant