Incorrect Handling of Bearer Token with trailing space in openidc_get_bearer_access_token #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space in openidc_get_bearer_access_token
gustoliv
changed the title
… space in openidc_get_bearer_access_token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
openidc_get_bearer_access_tokenfunction by trimming whitespace from headers and ensuring proper validation of the extracted access token. (Fixes #537)Changes
trimfunction to remove leading and trailing whitespace from headers before processing.nilto""sinceheader:sub(divider + 1)always return a string."") rather thannil.Impact
These improvements enhance robustness and prevent potential issues with incorrectly formatted headers.
Test Results
After these changes, the unit tests improved from 498 successes / 11 failures to 503 successes / 0 failures.
Before:
After: