Skip to content

Commit b05ae59

Browse files
authored
test: fix failing backup system tests (googleapis#2)
* Remove unnecessary retention period setting * Fix systests
1 parent e007c5d commit b05ae59

File tree

1 file changed

+5
-17
lines changed

1 file changed

+5
-17
lines changed

tests/system/test_system.py

+5-17
Original file line numberDiff line numberDiff line change
@@ -598,22 +598,6 @@ def setUpClass(cls):
598598
op1.result(30) # raises on failure / timeout.
599599
op2.result(30) # raises on failure / timeout.
600600

601-
# Add retention period for backups
602-
retention_period = "7d"
603-
ddl_statements = DDL_STATEMENTS + [
604-
"ALTER DATABASE {}"
605-
" SET OPTIONS (version_retention_period = '{}')".format(
606-
cls.DATABASE_NAME, retention_period
607-
)
608-
]
609-
db = Config.INSTANCE.database(
610-
cls.DATABASE_NAME, pool=pool, ddl_statements=ddl_statements
611-
)
612-
operation = db.update_ddl(ddl_statements)
613-
# We want to make sure the operation completes.
614-
operation.result(240) # raises on failure / timeout.
615-
db.reload()
616-
617601
current_config = Config.INSTANCE.configuration_name
618602
same_config_instance_id = "same-config" + unique_resource_id("-")
619603
create_time = str(int(time.time()))
@@ -725,7 +709,11 @@ def test_backup_workflow(self):
725709
database = instance.database(restored_id)
726710
self.to_drop.append(database)
727711
operation = database.restore(source=backup)
728-
operation.result()
712+
restored_db = operation.result()
713+
self.assertEqual(version_time, restored_db.restore_info.backup_info.create_time)
714+
715+
metadata = operation.metadata
716+
self.assertEqual(version_time, metadata.backup_info.create_time)
729717

730718
database.drop()
731719
backup.delete()

0 commit comments

Comments
 (0)