Add plans to summary, counts unfinished plans as fails

Author: Hypercubed

example/run-test.js

@@ -1,8 +1,8 @@
 var exec = require('child_process').exec
 
-var tapeCmd = require.resolve('../node_modules/task-tape/bin/task-tape')
+var tapeCmd = require.resolve('../node_modules/.bin/tape')
 var tapCmd = require.resolve('../bin/cmd')
 var tests = require.resolve('./test')
-var extra = '--no-ansi --no-progress --markdown'
+var extra = ''
 
 exec([tapeCmd, tests, '|', tapCmd, extra].join(' ')).stdout.pipe(process.stdout)

example/test-error.js

@@ -0,0 +1,30 @@
+// https://gist.github.com/Hypercubed/f0e4514bc9aec5cc5c9e814bbc1dab2d
+// f431390d24fa067fb262d4ea03de3d77911b95bf
+var test = require('tape')
+var math = require('./math')
+
+test('t.plan', function(t) {
+  t.plan(3)
+
+  t.equal(
+    math.toFixed(2.385, 2),
+    '2.39'
+  )
+  next(function () {
+    t.equal(
+      math.toFixed(2.384, 2),
+      '2.38'
+    )
+    t.whatIsThisFunction();  // causes an uncaught error
+    t.equal(
+      math.toFixed(2, 2),
+      '2.00'
+    )
+  })
+})
+
+function next(fn) {
+  setTimeout(function() {
+    fn()
+  }, 100)
+}

example/test-pass.js

@@ -0,0 +1,54 @@
+var test = require('tape')
+var math = require('./math')
+
+test('t.plan', function(t) {
+  t.plan(3)
+
+  t.equal(
+    math.toFixed(2.385, 2),
+    '2.39'
+  )
+  next(function () {
+    t.equal(
+      math.toFixed(2.384, 2),
+      '2.38'
+    )
+    t.equal(
+      math.toFixed(2, 2),
+      '2.00'
+    )
+  })
+})
+
+test('t.end', function(t) {
+  t.equal(
+    math.precision(0),
+    0
+  )
+  t.equal(
+    math.precision(0.1),
+    1
+  )
+  var plan = 10
+  ;(function NEXT() {
+    next(function () {
+      t.equal(
+        math.precision(0.1),
+        1
+      )
+      plan--
+      if (plan) {
+        NEXT()
+      } else {
+        console.log('DONE')
+        t.end()
+      }
+    })
+  })()
+})
+
+function next(fn) {
+  setTimeout(function() {
+    fn()
+  }, 100)
+}

lib/summarize.js

@@ -44,20 +44,27 @@ module.exports = function () {
   tap.on('output', function (res) {
     handleTestEnd()
 
-    if (res.fail.length) {
-      dup.failed = true
+    var planned = res.plans.reduce(function (p, c) {
+      return c.to - c.from + 1 + p;
+    }, 0)
+
+    var failed = res.fail.length
+    var asserts = res.asserts.length
+
+    if (planned > asserts) {
+      failed += planned - asserts
     }
 
-    if (res.plans.length < 1) {
+    if (failed || planned === 0 || planned < asserts) {
       dup.failed = true
-      process.exit(1)
     }
 
     dup.emit('summary', {
       duration: duration,
+      planned: planned,
       assertions: res.asserts.length,
       pass: res.pass.length,
-      fail: res.fail.length,
+      fail: failed,
       comments: res.comments.length,
     }, res.fail.reduce(function (o, assertion) {
       var name = getTest(assertion.test, res.tests).name

lib/summary.js

@@ -75,6 +75,13 @@ module.exports = function (opts) {
     var output = [LF]
     output.push(splitter(' Summary '))
     output.push(format.cyan.escape(LIST + 'duration: ' + prettyMs(res.duration)))
+    if (res.planned < 1) {
+      output.push(format.red.escape(LIST + 'planned: NA (plans must appear once in output)'))
+    } else if (res.assertions !== res.planned) {
+      output.push(format.red.escape(LIST + 'planned: ' + res.planned + " (plans don't match final assertions)"))
+    } else {
+      output.push(format.cyan.escape(LIST + 'planned: ' + res.planned))
+    }
     output.push(format.cyan.escape(LIST + 'assertions: ' + res.assertions))
     if (res.pass) {
       output.push(format.green.escape(LIST + 'pass: ' + res.pass))
@@ -103,7 +110,7 @@ module.exports = function (opts) {
     var max = 80
     var left = max - len >> 1
     return format.yellow.escape(
-      repeat('-', left) + (s || '') + repeat('-', max - len - left)
+      repeat('-', left) + (s || '') + repeat('-', max - len - left) + LF
     )
   }