Skip to content

freeze on path highlighting when directory have many files #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msva opened this issue Nov 24, 2017 · 7 comments
Closed

freeze on path highlighting when directory have many files #456

msva opened this issue Nov 24, 2017 · 7 comments

Comments

@msva
Copy link

msva commented Nov 24, 2017

I've found, that zsh-syntax-highlight freezes zsh when I trying to enter some path, when last entered (before the freeze) directory contains many files (i.e. even ls thinks for some time before show the files).

Also, it seems, there is no way to tell the highlighter to don't try to not perform any operations on that dir (I guess, it is somehow related to the check if last path's part is existing file or not) and just highligt it in some predefined way...

@danielshahaf
Copy link
Member

I'm guessing it's just being slow, not actually freezes, and this is a duplicate of #379.

@msva
Copy link
Author

msva commented Nov 24, 2017

Yeah, thanks, it is. I was just unable to find it by any of keywords I tried :)

@msva msva closed this as completed Nov 24, 2017
@danielshahaf
Copy link
Member

Cheers. Any chance you'd like to help with the implementation? (We're also on #zsh-syntax-highlighting on freenode)

@phy1729
Copy link
Member

phy1729 commented Feb 11, 2018

@msva If you get a chance, feedback on #496 would be appreciated.

@msva
Copy link
Author

msva commented Feb 16, 2018

Well, it looks good for me :) But I guess, it's only @nicoulaj who can merge it. Isn't he?

@msva
Copy link
Author

msva commented Feb 16, 2018

by the way, I guess, if you sure that new features (like ${:|} and :P) have better performance, you can add $ZSH_VERSION check (but it's just my humble opinion and can be unacceptable here. I'd anyway wait for @nicoulaj comments on your PR...

@danielshahaf
Copy link
Member

@msva: @phy1729 and I have push access as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants