Skip to content

Un-functional brackets in string is still highlighted #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giappi opened this issue Jun 17, 2021 · 2 comments
Open

Un-functional brackets in string is still highlighted #817

giappi opened this issue Jun 17, 2021 · 2 comments

Comments

@giappi
Copy link

giappi commented Jun 17, 2021

Dear author,

I found an issue.
The brackets in string is still highlighted, although it doesn't have any function (just is text).
Expected: All characters in a string that does not have any special function should not be highlighted.
I think it is a bug.
See the image bellow:

Screenshot from 2021-06-17 22-02-26

Best Regards,
(a zsh user)

@danielshahaf
Copy link
Member

The incumbent behaviour could be helpful for perl -e '…' and git commit -m '…', though? I don't use the brackets highlighter. Excuse brevity.

@phy1729
Copy link
Member

phy1729 commented Jun 20, 2021

That was the original behavior. The brackets highlighter was changed in #455 in response to #112 and #138. The issue with ignoring brackets in quotes is quoting contexts nest and it's difficult to parse something like "${foo:-"{bar}"}" without significantly increasing the highlighter complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants