api [nfc]: Rename subject/topic on UpdateMessageEvent

This completes the renaming from "subject" to "topic" in our code.

Author: gnprice

lib/api/model/events.dart

@@ -623,8 +623,12 @@ class UpdateMessageEvent extends Event {
   final int? streamId;
   final int? newStreamId;
   final PropagateMode? propagateMode;
-  final String? origSubject;
-  final String? subject;
+
+  @JsonKey(name: 'orig_subject')
+  final String? origTopic;
+  @JsonKey(name: 'subject')
+  final String? topic;
+
   // final List<TopicLink> topicLinks; // TODO handle
   final String? origContent;
   final String? origRenderedContent;
@@ -644,8 +648,8 @@ class UpdateMessageEvent extends Event {
     required this.streamId,
     required this.newStreamId,
     required this.propagateMode,
-    required this.origSubject,
-    required this.subject,
+    required this.origTopic,
+    required this.topic,
     required this.origContent,
     required this.origRenderedContent,
     required this.content,

lib/api/model/events.g.dart

@@ -27,6 +27,25 @@ extension MessageEventChecks on Subject<MessageEvent> {
   Subject<Message> get message => has((e) => e.message, 'message');
 }
 
+extension UpdateMessageEventChecks on Subject<UpdateMessageEvent> {
+  Subject<int?> get userId => has((e) => e.userId, 'userId');
+  Subject<bool?> get renderingOnly => has((e) => e.renderingOnly, 'renderingOnly');
+  Subject<int> get messageId => has((e) => e.messageId, 'messageId');
+  Subject<List<int>> get messageIds => has((e) => e.messageIds, 'messageIds');
+  Subject<List<MessageFlag>> get flags => has((e) => e.flags, 'flags');
+  Subject<int?> get editTimestamp => has((e) => e.editTimestamp, 'editTimestamp');
+  Subject<int?> get streamId => has((e) => e.streamId, 'streamId');
+  Subject<int?> get newStreamId => has((e) => e.newStreamId, 'newStreamId');
+  Subject<PropagateMode?> get propagateMode => has((e) => e.propagateMode, 'propagateMode');
+  Subject<String?> get origTopic => has((e) => e.origTopic, 'origTopic');
+  Subject<String?> get topic => has((e) => e.topic, 'topic');
+  Subject<String?> get origContent => has((e) => e.origContent, 'origContent');
+  Subject<String?> get origRenderedContent => has((e) => e.origRenderedContent, 'origRenderedContent');
+  Subject<String?> get content => has((e) => e.content, 'content');
+  Subject<String?> get renderedContent => has((e) => e.renderedContent, 'renderedContent');
+  Subject<bool?> get isMeMessage => has((e) => e.isMeMessage, 'isMeMessage');
+}
+
 extension HeartbeatEventChecks on Subject<HeartbeatEvent> {
   // No properties not covered by Event.
 }

test/api/model/events_checks.dart

@@ -66,6 +66,30 @@ void main() {
     check(mkEvent([MessageFlag.read])).message.flags.deepEquals([MessageFlag.read]);
   });
 
+  group('update_message', () {
+    final message = eg.streamMessage();
+    final baseJson = {
+      'id': 1,
+      'type': 'update_message',
+      'user_id': eg.selfUser.userId,
+      'rendering_only': false,
+      'message_id': message.id,
+      'message_ids': [message.id],
+      'flags': <String>[],
+      'edit_timestamp': 1718741351,
+      'stream_id': eg.stream().streamId,
+    };
+
+    test('orig_subject -> origTopic, subject -> topic', () {
+      check(Event.fromJson({ ...baseJson,
+        'orig_subject': 'foo',
+        'subject': 'bar',
+      }) as UpdateMessageEvent)
+        ..origTopic.equals('foo')
+        ..topic.equals('bar');
+    });
+  });
+
   test('delete_message: require streamId and topic for stream messages', () {
     check(() => DeleteMessageEvent.fromJson({
       'id': 1,

test/api/model/events_test.dart

@@ -410,8 +410,8 @@ UpdateMessageEvent updateMessageEditEvent(
     streamId: origMessage is StreamMessage ? origMessage.streamId : null,
     newStreamId: null,
     propagateMode: null,
-    origSubject: null,
-    subject: null,
+    origTopic: null,
+    topic: null,
     origContent: 'some probably-mismatched old Markdown',
     origRenderedContent: origMessage.content,
     content: 'some probably-mismatched new Markdown',