types: Again make toplevel-declared types exact, where no errors.

Similar to 7037393 a few months ago: done for the same reasons,
and in the exact same way.

The remaining cases that cause errors are mostly examples of #3451,
so we can convert them to exact object types as we fix that.

And then there are a handful of types that are genuinely meant to
be inexact object types.  When we upgrade soon to Flow v0.84 (as
part of #3399), we can make those explicit; tracking that as #3452.

Author: gnprice

src/api/registerForEvents.js

@@ -3,7 +3,7 @@ import type { Auth } from './transportTypes';
 import type { Narrow } from './apiTypes';
 import { apiPost, objectToParams } from './apiFetch';
 
-type RegisterForEventsParams = {
+type RegisterForEventsParams = {|
   apply_markdown?: boolean,
   client_gravatar?: boolean,
   all_public_streams?: boolean,
@@ -12,7 +12,7 @@ type RegisterForEventsParams = {
   include_subscribers?: boolean,
   narrow?: Narrow,
   queue_lifespan_secs?: number,
-};
+|};
 
 /** See https://zulipchat.com/api/register-queue */
 export default (auth: Auth, params: RegisterForEventsParams) =>

src/api/users/updateUserStatus.js

@@ -2,10 +2,10 @@
 import type { ApiResponseSuccess, Auth } from '../transportTypes';
 import { apiPost, objectToParams } from '../apiFetch';
 
-type UserStatusParams = {
+type UserStatusParams = {|
   away?: boolean,
   status_text?: string,
-};
+|};
 
 export default (auth: Auth, params: UserStatusParams): Promise<ApiResponseSuccess> =>
   apiPost(auth, 'users/me/status', objectToParams(params));

src/common/GroupAvatar.js

@@ -17,13 +17,13 @@ const styles = StyleSheet.create({
   },
 });
 
-type Props = {
+type Props = {|
   names: string,
   size: number,
   shape: 'rounded' | 'square',
   children?: React$Node,
   onPress?: () => void,
-};
+|};
 
 /**
  * Renders a text avatar based on a single or multiple user's

src/common/UserAvatar.js

@@ -5,13 +5,13 @@ import { ImageBackground, View } from 'react-native';
 import type { Node as React$Node } from 'react';
 import Touchable from './Touchable';
 
-type Props = {
+type Props = {|
   avatarUrl: string,
   size: number,
   shape: 'rounded' | 'square',
   children?: React$Node,
   onPress?: () => void,
-};
+|};
 
 /**
  * Renders an image of the user's avatar.

src/title-buttons/titleButtonFromNarrow.js

@@ -19,10 +19,10 @@ import ExtraNavButtonTopic from './ExtraNavButtonTopic';
 
 type Props = {| color: string, narrow: Narrow |};
 type NarrowNavButton = ComponentType<Props>;
-type NarrowNavButtonCandidate = {
+type NarrowNavButtonCandidate = {|
   isFunc: Narrow => boolean,
   ButtonComponent: NarrowNavButton | null,
-};
+|};
 
 const infoButtonHandlers: NarrowNavButtonCandidate[] = [
   { isFunc: isHomeNarrow, ButtonComponent: null },

src/user-status/UserStatusScreen.js

@@ -24,14 +24,14 @@ const styles = StyleSheet.create({
   },
 });
 
-type Props = {
+type Props = {|
   dispatch: Dispatch,
   userStatusText: string,
-};
+|};
 
-type State = {
+type State = {|
   statusText: string,
-};
+|};
 
 class UserStatusScreen extends PureComponent<Props, State> {
   state = {