connect: Convert remaining error sites to use "fixme" version.

These are the call sites that show type errors when we
switch to the upcoming improved `connect` type that lets
the type-checker work.

Done mechanically.  While on a version where `connect` had
the improved type, ran the following command:

  $ node_modules/.bin/flow status --json \
    | jq -r '
        .errors | map(.message[0].loc.source)[] ' \
    | sort -u \
    | xargs -r perl -i -0pe '
        s/\bconnect\b/connectFlowFixMe/g '

where the first few steps of the pipeline identify exactly the
files where Flow is reporting errors.  Then reviewed the diff
and fixed up by hand the one place (in RealmScreen) where the
word "connect" appeared as a false positive.

Author: gnprice

src/account-info/AccountDetailsScreen.js

@@ -3,7 +3,7 @@ import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { Dispatch, GlobalState, User } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { getAccountDetailsUserFromEmail } from '../selectors';
 import { Screen, ZulipButton } from '../common';
 import { IconPrivateChat } from '../common/Icons';
@@ -52,6 +52,6 @@ class AccountDetailsScreen extends PureComponent<Props> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   user: getAccountDetailsUserFromEmail(state, props.navigation.state.params.email),
 }))(AccountDetailsScreen);

src/autocomplete/TopicAutocomplete.js

@@ -4,7 +4,7 @@ import React, { PureComponent } from 'react';
 import { FlatList, StyleSheet } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { getTopicsForNarrow } from '../selectors';
 import { Popup, RawLabel, Touchable } from '../common';
 import AnimatedScaleComponent from '../animation/AnimatedScaleComponent';
@@ -55,6 +55,6 @@ class TopicAutocomplete extends PureComponent<Props> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   topics: getTopicsForNarrow(props.narrow)(state),
 }))(TopicAutocomplete);

src/common/ZulipStatusBar.js

@@ -5,7 +5,7 @@ import { Platform, StatusBar, View } from 'react-native';
 import Color from 'color';
 
 import type { Dimensions, GlobalState, Narrow, Orientation, ThemeName, Dispatch } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { DEFAULT_TITLE_BACKGROUND_COLOR, getTitleBackgroundColor } from '../title/titleSelectors';
 import { foregroundColorFromBackground } from '../utils/color';
 import { getSession, getSettings } from '../selectors';
@@ -66,7 +66,7 @@ class ZulipStatusBar extends PureComponent<Props> {
   }
 }
 
-export default connect(
+export default connectFlowFixMe(
   (state: GlobalState, props: { backgroundColor?: string, narrow?: Narrow }) => ({
     safeAreaInsets: getSession(state).safeAreaInsets,
     theme: getSettings(state).theme,

src/message/NotSubscribed.js

@@ -4,7 +4,7 @@ import React, { PureComponent } from 'react';
 import { View } from 'react-native';
 
 import type { Auth, Stream, Dispatch } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { subscriptionAdd } from '../api';
 import { ZulipButton, Label } from '../common';
 import { getAuth, getStreamInNarrow } from '../selectors';
@@ -40,7 +40,7 @@ class NotSubscribed extends PureComponent<Props> {
   }
 }
 
-export default connect((state, props) => ({
+export default connectFlowFixMe((state, props) => ({
   auth: getAuth(state),
   stream: getStreamInNarrow(props.narrow)(state),
 }))(NotSubscribed);

src/start/RealmScreen.js

@@ -4,7 +4,7 @@ import { ScrollView, Keyboard } from 'react-native';
 import type { NavigationScreenProp } from 'react-navigation';
 
 import type { ApiResponseServerSettings, Dispatch } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { ErrorMsg, Label, SmartUrlInput, Screen, ZulipButton } from '../common';
 import { isValidUrl } from '../utils/url';
 import { getServerSettings } from '../api';
@@ -95,7 +95,7 @@ class RealmScreen extends PureComponent<Props, State> {
   }
 }
 
-export default connect((state, props) => ({
+export default connectFlowFixMe((state, props) => ({
   initialRealm:
     (props.navigation && props.navigation.state.params && props.navigation.state.params.realm)
     || '',

src/streams/EditStreamScreen.js

@@ -2,7 +2,7 @@
 import React, { PureComponent } from 'react';
 
 import type { Dispatch, GlobalState, Stream } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { updateExistingStream, navigateBack } from '../actions';
 import { getStreamFromId } from '../selectors';
 import { Screen } from '../common';
@@ -36,6 +36,6 @@ class EditStreamScreen extends PureComponent<Props> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   stream: getStreamFromId(state, props.navigation.state.params.streamId),
 }))(EditStreamScreen);

src/streams/InviteUsersScreen.js

@@ -2,7 +2,7 @@
 import React, { PureComponent } from 'react';
 
 import type { Auth, Dispatch, GlobalState, Stream, User } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { Screen } from '../common';
 import { navigateBack } from '../actions';
 import { subscriptionAdd } from '../api';
@@ -44,7 +44,7 @@ class InviteUsersScreen extends PureComponent<Props, State> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   auth: getAuth(state),
   stream: getStreamFromId(state, props.navigation.state.params.streamId),
 }))(InviteUsersScreen);

src/streams/StreamScreen.js

@@ -3,7 +3,7 @@ import React, { PureComponent } from 'react';
 import { View } from 'react-native';
 
 import type { Dispatch, GlobalState, Stream, Subscription } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { delay } from '../utils/async';
 import { OptionRow, Screen, ZulipButton, OptionDivider } from '../common';
 import { getIsAdmin, getStreamFromId, getSubscriptionFromId } from '../selectors';
@@ -98,7 +98,7 @@ class StreamScreen extends PureComponent<Props> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   isAdmin: getIsAdmin(state),
   stream: getStreamFromId(state, props.navigation.state.params.streamId),
   subscription: getSubscriptionFromId(state, props.navigation.state.params.streamId),

src/streams/SubscriptionsCard.js

@@ -4,7 +4,7 @@ import React, { PureComponent } from 'react';
 import { View, StyleSheet } from 'react-native';
 
 import type { Dispatch, Narrow, Subscription, GlobalState } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import StreamList from './StreamList';
 import { isStreamNarrow, streamNarrow } from '../utils/narrow';
 import { getUnreadByStream } from '../selectors';
@@ -47,7 +47,7 @@ class SubscriptionsCard extends PureComponent<Props> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   narrow: props.narrow || [],
   // Main screen no longer contains drawer,
   // so at any position we cannot show selected stream in the list

src/title/ActivityText.js

@@ -3,7 +3,7 @@
 import React, { PureComponent } from 'react';
 
 import type { Style, UserPresence, UserStatus, Dispatch } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { getPresence, getUserStatus } from '../selectors';
 import { presenceToHumanTime } from '../utils/presence';
 import { RawLabel } from '../common';
@@ -29,7 +29,7 @@ class ActivityText extends PureComponent<Props> {
   }
 }
 
-export default connect((state, props) => ({
+export default connectFlowFixMe((state, props) => ({
   presence: getPresence(state)[props.user.email],
   userStatus: getUserStatus(state)[props.user.user_id],
 }))(ActivityText);

src/title/TitleGroup.js

@@ -4,7 +4,7 @@ import React, { PureComponent } from 'react';
 import { StyleSheet, View } from 'react-native';
 
 import type { Dispatch, UserOrBot } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { UserAvatarWithPresence } from '../common';
 import { getRecipientsInGroupNarrow } from '../selectors';
 import styles from '../styles';
@@ -47,6 +47,6 @@ class TitleGroup extends PureComponent<Props> {
   }
 }
 
-export default connect((state, props) => ({
+export default connectFlowFixMe((state, props) => ({
   recipients: getRecipientsInGroupNarrow(state, props.narrow),
 }))(TitleGroup);

src/title/TitlePrivate.js

@@ -4,7 +4,7 @@ import React, { PureComponent } from 'react';
 import { StyleSheet, Text, View } from 'react-native';
 
 import type { Dispatch, UserOrBot } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { Touchable, UserAvatarWithPresence, ViewPlaceholder } from '../common';
 import ActivityText from './ActivityText';
 import { getAllUsersByEmail } from '../users/userSelectors';
@@ -47,6 +47,6 @@ class TitlePrivate extends PureComponent<Props> {
   }
 }
 
-export default connect((state, props) => ({
+export default connectFlowFixMe((state, props) => ({
   user: getAllUsersByEmail(state).get(props.email),
 }))(TitlePrivate);

src/topics/TopicListScreen.js

@@ -3,7 +3,7 @@
 import React, { PureComponent } from 'react';
 
 import type { Dispatch, GlobalState, Stream, TopicExtended } from '../types';
-import { connect } from '../react-redux';
+import { connectFlowFixMe } from '../react-redux';
 import { Screen } from '../common';
 import { topicNarrow } from '../utils/narrow';
 import { getTopicsForStream } from '../selectors';
@@ -52,7 +52,7 @@ class TopicListScreen extends PureComponent<Props, State> {
   }
 }
 
-export default connect((state: GlobalState, props) => ({
+export default connectFlowFixMe((state: GlobalState, props) => ({
   stream: getStreamFromId(state, props.navigation.state.params.streamId),
   topics: getTopicsForStream(state, props.navigation.state.params.streamId),
 }))(TopicListScreen);