connect: Mass-migrate to our type-fixing wrapper.

This converts every reference to `connect` in our codebase to
go through this wrapper, giving us an easy single point of
control for the types Flow sees for `connect`.

If in the future we start using other features of `connect`
that the wrapper ignores, we can add them there; or add a
second wrapper with a different name, if that happens to be
easier.  (No reason we have to rely as heavily on overloading
as the upstream `connect` does.)

Done mechanically, like so:

  $ perl -i -0pe '
      s<^import \{ connect \} from .react-redux..\n>
       <>m || next;
      s<from .[./]*/types.;\n\K>
       <import { connect } from '\''../react-redux'\'';\n>ms;
    ' src/**/*.js

Author: gnprice

src/account-info/AccountDetails.js

@@ -1,9 +1,9 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
 import { View, StyleSheet } from 'react-native';
-import { connect } from 'react-redux';
 
 import type { GlobalState, User, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { UserAvatar, ComponentList, RawLabel } from '../common';
 import { getCurrentRealm, getUserStatusTextForUser } from '../selectors';
 import PresenceStatusIndicator from '../common/PresenceStatusIndicator';

src/account-info/AccountDetailsScreen.js

@@ -1,9 +1,9 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
-import { connect } from 'react-redux';
 
 import type { Dispatch, GlobalState, User } from '../types';
+import { connect } from '../react-redux';
 import { getAccountDetailsUserFromEmail } from '../selectors';
 import { Screen, ZulipButton } from '../common';
 import { IconPrivateChat } from '../common/Icons';

src/account-info/AwayStatusSwitch.js

@@ -1,8 +1,8 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
-import { connect } from 'react-redux';
 
 import type { Dispatch, GlobalState } from '../types';
+import { connect } from '../react-redux';
 import { OptionRow } from '../common';
 import { getSelfUserAwayStatus } from '../selectors';
 import { updateUserAwayStatus } from '../user-status/userStatusActions';

src/account-info/ProfileCard.js

@@ -1,9 +1,9 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
 import { ScrollView, StyleSheet, View } from 'react-native';
-import { connect } from 'react-redux';
 
 import type { Dispatch, GlobalState, User } from '../types';
+import { connect } from '../react-redux';
 import { getSelfUserDetail } from '../selectors';
 import { ZulipButton } from '../common';
 import {

src/account/AccountPickScreen.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { Dispatch, GlobalState } from '../types';
+import { connect } from '../react-redux';
 import { hasAuth, getAccountStatuses } from '../selectors';
 import type { AccountStatus } from './accountsSelectors';
 import { Centerer, ZulipButton, Logo, Screen } from '../common';

src/autocomplete/EmojiAutocomplete.js

@@ -1,5 +1,4 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { FlatList } from 'react-native';
@@ -8,6 +7,7 @@ import { Popup } from '../common';
 import EmojiRow from '../emoji/EmojiRow';
 import { getFilteredEmojiNames } from '../emoji/data';
 import type { GlobalState, RealmEmojiById, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getActiveImageEmojiByName } from '../selectors';
 
 type Props = {|

src/autocomplete/PeopleAutocomplete.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { SectionList } from 'react-native';
 
 import type { User, UserGroup, GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getOwnEmail, getSortedUsers, getUserGroups } from '../selectors';
 import {
   getAutocompleteSuggestion,

src/autocomplete/StreamAutocomplete.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { FlatList } from 'react-native';
 
 import type { GlobalState, SubscriptionsState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { Popup } from '../common';
 import { getSubscribedStreams } from '../subscriptions/subscriptionSelectors';
 import StreamItem from '../streams/StreamItem';

src/autocomplete/TopicAutocomplete.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { FlatList, StyleSheet } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getTopicsForNarrow } from '../selectors';
 import { Popup, RawLabel, Touchable } from '../common';
 import AnimatedScaleComponent from '../animation/AnimatedScaleComponent';

src/boot/AppDataFetcher.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import { PureComponent } from 'react';
 
 import type { Node as React$Node } from 'react';
 import type { Dispatch, GlobalState } from '../types';
+import { connect } from '../react-redux';
 import { getSession } from '../directSelectors';
 import { doInitialFetch } from '../actions';
 

src/boot/AppEventHandlers.js

@@ -1,5 +1,4 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { AppState, NetInfo, View, StyleSheet, Platform, NativeModules } from 'react-native';
@@ -8,6 +7,7 @@ import Orientation from 'react-native-orientation';
 
 import type { Node as React$Node } from 'react';
 import type { Dispatch, GlobalState, Orientation as OrientationT } from '../types';
+import { connect } from '../react-redux';
 import { getUnreadByHuddlesMentionsAndPMs } from '../selectors';
 import { handleInitialNotification, NotificationListener } from '../notification';
 import {

src/boot/StylesProvider.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 
 import type { Node as React$Node } from 'react';
 import type { GlobalState, ThemeName, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getSettings } from '../directSelectors';
 import { stylesFromTheme, themeColors, ThemeContext } from '../styles/theme';
 

src/boot/TranslationProvider.js

@@ -1,12 +1,12 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 import React, { PureComponent } from 'react';
 import type { ComponentType, ElementConfig, Node as React$Node } from 'react';
 import { Text } from 'react-native';
 import { IntlProvider } from 'react-intl';
 import type { IntlShape } from 'react-intl';
 
 import type { GetText, GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getSettings } from '../selectors';
 import '../../vendor/intl/intl';
 import messages from '../i18n/messages';

src/chat/Chat.js

@@ -1,9 +1,9 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
 import { View, StyleSheet } from 'react-native';
-import { connect } from 'react-redux';
 
 import type { GlobalState, Narrow, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { KeyboardAvoider } from '../common';
 import MessageList from '../webview/MessageList';
 import NoMessages from '../message/NoMessages';

src/chat/GroupDetailsScreen.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 import React, { PureComponent } from 'react';
 import { FlatList } from 'react-native';
 import type { NavigationScreenProp } from 'react-navigation';
 
 import type { Dispatch, UserOrBot } from '../types';
+import { connect } from '../react-redux';
 import { Screen } from '../common';
 import UserItem from '../users/UserItem';
 import { navigateToAccountDetails } from '../actions';

src/chat/MarkUnreadButton.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { Auth, GlobalState, Narrow, Stream, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { ZulipButton } from '../common';
 import { markAllAsRead, markStreamAsRead, markTopicAsRead } from '../api';
 import { getAuth, getStreams } from '../selectors';

src/chat/UnreadNotice.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet, View } from 'react-native';
 
 import type { Narrow, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getUnreadCountForNarrow } from '../selectors';
 import { Label, RawLabel } from '../common';
 import { unreadToLimitedCount } from '../utils/unread';

src/common/OfflineNotice.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getSession } from '../selectors';
 import Label from './Label';
 

src/common/OwnAvatar.js

@@ -1,8 +1,8 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
-import { connect } from 'react-redux';
 
 import type { GlobalState, User, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getCurrentRealm, getSelfUserDetail } from '../selectors';
 import UserAvatar from './UserAvatar';
 import { getAvatarFromUser } from '../utils/avatar';

src/common/PresenceStatusIndicator.js

@@ -2,7 +2,6 @@
 /* eslint-disable react-native/no-unused-styles */
 import React, { PureComponent } from 'react';
 import { StyleSheet, View } from 'react-native';
-import { connect } from 'react-redux';
 
 import type {
   GlobalState,
@@ -12,6 +11,7 @@ import type {
   UserStatusMapObject,
   Dispatch,
 } from '../types';
+import { connect } from '../react-redux';
 import { statusFromPresenceAndUserStatus } from '../utils/presence';
 import { getPresence, getUserStatus } from '../selectors';
 import { getUsersByEmail } from '../users/userSelectors';

src/common/Screen.js

@@ -1,11 +1,11 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import type { Node as React$Node } from 'react';
 import { StyleSheet, View, ScrollView } from 'react-native';
 
 import type { Context, Dimensions, GlobalState, LocalizableText, Style, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import KeyboardAvoider from './KeyboardAvoider';
 import OfflineNotice from './OfflineNotice';
 import ZulipStatusBar from './ZulipStatusBar';

src/common/UserAvatarWithPresence.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { getCurrentRealm } from '../selectors';
 import UserAvatar from './UserAvatar';
 import { getAvatarUrl } from '../utils/avatar';

src/common/WebLink.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import Label from './Label';
 import { getFullUrl } from '../utils/url';
 import openLink from '../utils/openLink';

src/common/ZulipStatusBar.js

@@ -1,11 +1,11 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { Platform, StatusBar, View } from 'react-native';
 import Color from 'color';
 
 import type { Dimensions, GlobalState, Narrow, Orientation, ThemeName, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { DEFAULT_TITLE_BACKGROUND_COLOR, getTitleBackgroundColor } from '../title/titleSelectors';
 import { foregroundColorFromBackground } from '../utils/color';
 import { getSession, getSettings } from '../selectors';

src/compose/ComposeBox.js

@@ -1,7 +1,6 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
 import { Platform, View, TextInput, findNodeHandle } from 'react-native';
-import { connect } from 'react-redux';
 import TextInputReset from 'react-native-text-input-reset';
 
 import type {
@@ -15,6 +14,7 @@ import type {
   Dimensions,
   GlobalState,
 } from '../types';
+import { connect } from '../react-redux';
 import {
   addToOutbox,
   cancelEditMessage,

src/compose/ComposeMenu.js

@@ -3,9 +3,9 @@ import React, { PureComponent } from 'react';
 import { View } from 'react-native';
 // $FlowFixMe
 import ImagePicker from 'react-native-image-picker';
-import { connect } from 'react-redux';
 
 import type { Dispatch, Narrow } from '../types';
+import { connect } from '../react-redux';
 import { showErrorAlert } from '../utils/info';
 import styles from '../styles';
 import { IconPlus, IconLeft, IconPeople, IconImage, IconCamera } from '../common/Icons';

src/diagnostics/DiagnosticsScreen.js

@@ -1,11 +1,11 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet } from 'react-native';
 
 import DeviceInfo from 'react-native-device-info';
 import type { Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { OptionButton, OptionDivider, Screen, RawLabel } from '../common';
 import {
   navigateToDebug,

src/diagnostics/StorageScreen.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { FlatList } from 'react-native';
 
 import type { GlobalState, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { Screen } from '../common';
 import SizeItem from './SizeItem';
 

src/emoji/EmojiPickerScreen.js

@@ -1,5 +1,4 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { FlatList } from 'react-native';
@@ -11,6 +10,7 @@ import { Screen } from '../common';
 import EmojiRow from './EmojiRow';
 import { getFilteredEmojiNames } from './data';
 import type { GlobalState, RealmEmojiById, Auth, Dispatch, ReactionType } from '../types';
+import { connect } from '../react-redux';
 import { getAuth, getActiveImageEmojiByName } from '../selectors';
 import { navigateBack } from '../nav/navActions';
 import zulipExtraEmojiMap from './zulipExtraEmojiMap';

src/emoji/EmojiRow.js

@@ -1,9 +1,9 @@
 /* @flow strict-local */
 import React, { PureComponent } from 'react';
-import { connect } from 'react-redux';
 import { StyleSheet, View } from 'react-native';
 
 import type { GlobalState, ImageEmojiType, Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { RawLabel, Touchable } from '../common';
 import Emoji from './Emoji';
 import ImageEmoji from './ImageEmoji';

src/lightbox/Lightbox.js

@@ -1,12 +1,12 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { View, StyleSheet, Dimensions, Easing } from 'react-native';
 import PhotoView from 'react-native-photo-view';
 import { connectActionSheet } from '@expo/react-native-action-sheet';
 
 import type { Auth, Dispatch, GlobalState, Message } from '../types';
+import { connect } from '../react-redux';
 import type { ShowActionSheetWithOptions } from '../message/messageActionSheet';
 import { getAuth } from '../selectors';
 import { getResource } from '../utils/url';

src/main/HomeTab.js

@@ -1,10 +1,10 @@
 /* @flow strict-local */
-import { connect } from 'react-redux';
 
 import React, { PureComponent } from 'react';
 import { StyleSheet, View } from 'react-native';
 
 import type { Dispatch } from '../types';
+import { connect } from '../react-redux';
 import { HOME_NARROW, MENTIONED_NARROW, STARRED_NARROW } from '../utils/narrow';
 import NavButton from '../nav/NavButton';
 import UnreadCards from '../unread/UnreadCards';