Skip to content

Commit ed490db

Browse files
committed
flow: Remove old fixme eliminated by upgrade.
As the `$FlowFixMe-56` indicates, this was introduced in the upgrade of RN to v0.56 (and corresponding upgrade of Flow)... and the comment doesn't sound like we had much idea at the time what the error actually meant. Now with the upcoming upgrade to RN v0.59 and of Flow to v0.92, the error this applies to disappears. Its disappearance seems just as mysterious as its presence... it could be that it was just a bug and there never was a type error, or it could be that the line the error is reported on has moved around so that it's covered by a different fixme comment, or something else. Well, drop the fixme. This also lets us re-enable failing on unused fixmes.
1 parent dfbdd97 commit ed490db

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.flowconfig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ esproposal.optional_chaining=enable
5959
esproposal.nullish_coalescing=enable
6060

6161
# The main warning is "Unused suppression comment".
62-
# Temporarily disabled to smooth the RN upgrade.
63-
# include_warnings=true
62+
include_warnings=true
6463

6564
module.system=haste
6665
module.system.haste.use_name_reducers=true

src/nav/AppWithNavigation.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ class AppWithNavigation extends PureComponent<Props> {
2121
const addListener = createReduxBoundAddListener('root');
2222

2323
return (
24-
// $FlowFixMe-56 flow-typed object type is incompatible with statics of React.Component
2524
<AppNavigator
2625
navigation={addNavigationHelpers({
2726
state: nav,

0 commit comments

Comments
 (0)