#226: fix for external-from-external dependencies (exposed by addition of dereferencedCache)

[mummybot]

This change resolves bug #226 and the PRs #146 and #223.

The if/then flow in the crawl functions of bundle and particularly dereference were such that if a match was found it would stop processing additional properties which may also contain $refs to be dereferenced.

[mummybot]

Sorry to poke, but will this PR be looked at? Are there changes that I need to make, or is this outside of the structure of what json-schem-ref-parser will parse?

[philsturgeon]

I'm not sure I understand what the bespokeKey is all about:

https://github.com/APIDevTools/json-schema-ref-parser/pull/230/files#diff-8149d22393a75a49f799c7bfdad7f3d69e6d2eb57a46eb032f11b2292fb0ea98R16-R33

[mummybot]

It highlights that a property sibling adjacent to a $ref doesn't get crawled and parsed currently. $bespokeKey is a representation of a custom keyword as allowed by Ajv, but it equally applies to the not property, which is valid JSON schema; we use a $ref for including long enum arrays.

[philsturgeon]

Sorry I'm trying to figure out the problems with GitHub Actions, I might have just done it, but we've got some conflicts now. Could you have a look?

[mummybot]

I'll fix the conflicts tomorrow.

[mummybot]

Conflicts resolved @philsturgeon

[mummybot]

Sorry to poke, any more movement on this PR? We are currently blocked from upgrading json-schema-ref-parser until this is merged.

[philsturgeon]

@P0lip could I get your input on this one? We've fixed the status checks, and there are no more conflicts, just need to figure out if this is something we want to merge.

[mummybot]

@P0lip sorry for chasing, but is this something which you will consider?

[mummybot]

Sorry to bug again, this is sitting in our backlog as a blocker and I have to justify it every morning. @P0lip / @philsturgeon is this ever going to be looked at, or shall I just close it as a "won't fix"?

[mummybot]

@philsturgeon will this PR be reviewed and maybe merged? We still have it outstanding in our work backlog. If not, then fine and I will close it.

[philsturgeon]

Hey, I know this has been going on for ages but I've never really understood what is happening in these tests.

What is $bespokeKey? are we adding some custom JSON Schema logic, or are you picking names that look like special characters with the intention of making sure keys with $ at the start still work?

The tests are just a bit confusing but it looks like a lot of effort has gone in here. Now that I've cleared some bugs and got the release pipeline working I am interested to get this sorted ASAP and will keep an eye out for updates.

[jonluca]

I'm closing stale PRs - happy to merge in a new PR if it's rebased

[mummybot]

God, it is so long ago that I looked at this, and I missed @philsturgeon's last message back in May 2022 :( I've no idea if this is still an issue, but the rebase is now horrendous, and I've moved projects.

If I encounter this issue again on a new project, I'll pick this up. A shame it didn't get added.