Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: External refs with overrides #317

Closed
wants to merge 1 commit into from

Conversation

simonbothen-radinn
Copy link

@simonbothen-radinn simonbothen-radinn commented Jun 2, 2023

The external resolver did not take into account for overrides. E.g take the following example:

$ref: 'base.yaml'
id: my_id
settings:
  $ref: 'base_settings.yaml'
  useCache: true

This failed to resolve on $ref: 'base_settings.yaml'. This is due to to root object passes $Ref.isExternal$Ref(obj) and therefore not considering the other child objects. We should still crawl the tree even though the root has a $ref.

@jonluca
Copy link
Collaborator

jonluca commented Sep 18, 2023

Included in #321

@jonluca jonluca closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants