Skip to content

nRF52840 USB Device Implementation #10689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jun 18, 2019
Merged

nRF52840 USB Device Implementation #10689

merged 42 commits into from
Jun 18, 2019

Conversation

AGlass0fMilk
Copy link
Member

Description

Implemented USBPhy on the Nordic nRF52840 target.

  • Added legacy driver files (nrf_drv_usbd.*)
  • Pulled in new errata fixes and driver changes from Nordic SDK version 15.3
  • Added implementation code for the USBPhy in usb/device/targets/TARGET_NORDIC/...

Extensive testing has been done and the basic USB test suite has passed hundreds of times. Admittedly, I have only been building with the GCC_ARM toolchain.

See comments on #7674 for test results

See original PR here: https://github.com/TacoGrandeTX/mbed-os/pull/10
This is a rebased version of this PR here: #10457
This is a rebased version (after SDK15 changes were pulled into master) of this PR here: #10526

Pull request type

[ ] Fix
[ ] Refactor
[ X ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170
@c1728p9

AGlass0fMilk added 30 commits May 28, 2019 10:48
@AGlass0fMilk
Configured sdk for enabling USB. Preliminary implementation of USB fo…
bd2605c 
…r nRF52840
@AGlass0fMilk
Changed power handler to enable/start & disable/stop USBD driver in b…
faa80d9 
…ackground
@AGlass0fMilk
Changed driver to request hf and lf clock sources... not sure why USB…
ceb3a10 
… Ready event isn't ever getting triggered
@AGlass0fMilk
Added errata fixes (171, 187) from nRF SDK 15.2 that would prevent US…
823067e 
…BD from starting up
@AGlass0fMilk
working on making the mbed and nordic drivers compatible
16b3511
@AGlass0fMilk
Non-working custom feeder. Modified nordic driver to disable automati…
bb65ee0 
…c EP0STATUS task triggering at end of DMA transfer
@AGlass0fMilk
Added in triggers to synchronize control transfer stages with what th…
4a735cb 
…e hardware expects. First working example!
@AGlass0fMilk
Added EP0 stalls to setup event handler
09c5982
@AGlass0fMilk
Removed disable from disconnect to see if it affects the success of t…
f000538 
…he soft reset test.
@AGlass0fMilk
Reviewing functions. Added critical sections to some functions that a…
c006888 
…ccess state information.
@AGlass0fMilk
Fixed bug causing usb_control_stall_test to fail intermittently. Prep…
608e326 
…aring the Nordic HW for the status stage of a control transfer would sometimes cause the HW to automatically ACK an "invalid" command during the control stall test. This would cause the test to fail (because an invalid request was not stalled).
@AGlass0fMilk
Removed 0 max packet size assert for ISO endpoints. Ensured usbd_ep_a…
0320ebc 
…bort would not be called on ISO endpoints (this currently causes an ASSERT in the Nordic driver
@AGlass0fMilk
Removed function call for SOF event -- frame counter is already inclu…
d3844a1 
…ded in data from usb event
@AGlass0fMilk
Added code to ignore ZLP packets on the ISOOUT endpoint... not fixing…
dde7bff 
… issue yet
@AGlass0fMilk
Changed a little formatting
859329f
@AGlass0fMilk
Added data toggle clearing to removing endpoints. Reworked aborting e…
4b744c8 
…ndpoints in nordic driver to prevent an ASSERT when it is called on ISO endpoints
@AGlass0fMilk
Implemented USBPhyHw::unconfigure() as it was causing configuration c…
94d01a9 
…hanges to fail. Endpoints were not being removed properly in the Nordic driver
@AGlass0fMilk
Added setup status enum and removed some old commented out code
1babcd1
@AGlass0fMilk
Trying virtual status stage and generated interrupt
171c8fa
@AGlass0fMilk
Added simulated status stage interrupt
cfea14c
@AGlass0fMilk
Added a return from the virtual status transfer software-triggered in…
54b72d2 
…terrupt. Not entirely sure this is appropriate.
@AGlass0fMilk
Ignore events that happen when an endpoint is stalled/halted
9e61bbc
@AGlass0fMilk
Added in flag for preventing double IRQ triggering and added asserts …
8c176c3 
…for Nordic driver calls
@AGlass0fMilk
Removed unnecessary logic and changed round robin DMA scheduling
7e15a5b
@AGlass0fMilk
Added workaround for "unloading" IN endpoints after unstalling. Disab…
40ee528 
…le and then reenable when USBPhyHw::endpoint_unhalt() is called.
@AGlass0fMilk
Removed redundant virtual status transfer notifications.
5d86c3b
@AGlass0fMilk
Fixing compatibilities with new nrfx drivers
2bd024d
@AGlass0fMilk
Finished compatibility changes for nrfx renaming
1ab27af
@AGlass0fMilk
Fixed IRQ_ENABLE call to IRQ_DISABLE (oops).
0fd7dca
@AGlass0fMilk
Fixed some comments
911c799
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 13, 2019

This should get into 5.13.1 (will reschedule CI once rc3 completes) . I reached out to @maciejbocianski to get review complete but should not block this any longer

@maciejbocianski
Copy link
Contributor

maciejbocianski commented Jun 13, 2019 •
edited
Loading

@AGlass0fMilk
I failed running USB tests on nRF52840-Preview-DK, all hanged at the beginning.
Is this preview version supported or maybe special board setup is required?

@AGlass0fMilk
Copy link
Member Author

@maciejbocianski The preview DK chips have so many USB-related errata that one Nordic employee said:
nordic-usb-quote

Can you try the tests on a production-quality nRF52840 DK?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 13, 2019

CI started

@maciejbocianski
Copy link
Contributor

@AGlass0fMilk
Yeah, I will try tomorrow

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

There's fix proposed in #10833, will restart CI after

@maciejbocianski
Copy link
Contributor

Unfortunately I don't have access to non-Preview version of the board to run the tests

@40Grit
Copy link

40Grit commented Jun 14, 2019 •
edited
Loading

@maciejbocianski

We can probably get one sent to you.
Contact @AGlass0fMilk and I at our @embeddedPlanet.com emails

See @Loverdeg for my email.

@40Grit
Copy link

40Grit commented Jun 14, 2019

Correction @loverdeg-ep for my email

maciejbocianski
maciejbocianski approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@maciejbocianski maciejbocianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wonder how to prevent running the USB stuff on nRF52840-Preview-DK board

@0Grit
Copy link

0Grit commented Jun 14, 2019

We literally destroyed all our PDK's. That solved most of our problems.

@0Grit
Copy link

0Grit commented Jun 14, 2019

Yes. In case that did not come through; I recommend anybody who reads this to destroy your NRF52840-PDK. Preview Development Kit

QSPI is irreparably broken, USB as well, among many other erratas.

Don't let somebody suffer by letting them borrow it or by giving it to them.

Literally snap it in half or sledge it and recycle it at an appropriate facility.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

Lots of random failures over the weekend. Restarting CI.

@mbed-ci
Copy link

mbed-ci commented Jun 17, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@AGlass0fMilk
Copy link
Member Author

@adbridge I'm having trouble viewing the details of why the greentea test failed. Is there any way the logs can be made public?

@adbridge
Copy link
Contributor

@AGlass0fMilk the current failures we think are internal to the CI. A fix has been applied and we are waiting to see if it has fixed things. If it has then I will restart the tests on here.

@0Grit
Copy link

0Grit commented Jun 17, 2019

@AGlass0fMilk Sounds like we need to make an issue for publication of the tests.
There are some discussions about this in issues/docs of this repository but also in the handbook.

@adbridge adbridge merged commit 07f1e06 into ARMmbed:master Jun 18, 2019
@AGlass0fMilk
Copy link
Member Author

Hooray! Resolves #7674

@AGlass0fMilk AGlass0fMilk mentioned this pull request Jun 19, 2019
Closed
@trowbridgec
Copy link

trowbridgec commented Jul 5, 2019 •
edited
Loading

I found an issue when updating to mbed-os-5.13.0 with an nRF52840 where the UART's RX didn't work (TX worked fine as I was getting debug data out of the board).

Initially, I updated to mbed-os-5.13.1 (we saw a tag for mbed-os-5.13.1 in our locally mirrored copy of mbed-os), and that seemed to fix the issue. I also tried using master, and the issue is fixed there as well.

After some troubleshooting, it turned out that cherry picking the commits from this PR re-enabled the UART RX.

@adbridge @0xc0170 @maclobdell

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2019

5.13.1 will be release in a week so should have the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maciejbocianski maciejbocianski maciejbocianski approved these changes

@c1728p9 c1728p9 Awaiting requested review from c1728p9

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@AGlass0fMilk @ciarmcom @j3hill @40Grit @adbridge @0xc0170 @maciejbocianski @mbed-ci @0Grit @trowbridgec