-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix STM32 radio driver when bandwidth is 0 #15217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecoutant
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LukaB, thank you for your changes. |
jeromecoutant
approved these changes
Jan 31, 2022
0xc0170
previously requested changes
Jan 31, 2022
80c597f
to
5059706
Compare
0xc0170
reviewed
Feb 2, 2022
A bug was detected when the uint8_t SUBGRF_GetFskBandwidthRegValue( uint32_t bandwidth ) is called and the bandwith argument has a value of 0. Comparing the code to the STMCubeWL 1.1 we can see that an if statement is missing to address the condition where bandwith is equal to 0. Added the if statement to the radio driver to account for this edge case.
5059706
to
d503495
Compare
0xc0170
approved these changes
Feb 7, 2022
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A bug was detected when the
uint8_t SUBGRF_GetFskBandwidthRegValue( uint32_t bandwidth )
is called and the bandwidth argument has a value of 0.
Comparing the code to the STMCubeWL 1.1 we can see that an if statement is missing to
address the condition where bandwidth is equal to 0.
Added the if statement to the radio driver to account for this edge case to prevent entering while (1) loop.
Impact of changes
Migration actions required
Documentation
None required.
But to replicate, I was using AS923-1, and then set my Gateway to have a maximum allowed data rate of DR_7.
The mBed device connected and quickly maxed out to DR_7 at which point the above function as called with bandwidth == 0.
Code from
radio_driver.c
(Line 1143):Pull request type
Test results
Reviewers
@jeromecoutant @hallard