[PW-1774]Implement SaleToAcquirerDataModel for sending SaleToAcq… #277
Conversation
…uirerData in the right format to Adyen.
rikterbeek
requested review from
AlexandrosMor,
martinsrenato and
rkewlani
as code owners
|
|
||
| import java.lang.reflect.Type; | ||
|
|
||
| public class SaleToAcquirerDataModelAdapterSerializer implements JsonSerializer<SaleToAcquirerDataModel> { |
There was a problem hiding this comment.
Any specific reason to mention Adapter in name of class ?
There was a problem hiding this comment.
not particular I will remove the adapter part.
| @@ -75,7 +79,8 @@ | |||
| * The Sale to acquirer data. | |||
| */ | |||
| @XmlElement(name = "SaleToAcquirerData") | |||
| protected String saleToAcquirerData; | |||
| @JsonAdapter(SaleToAcquirerDataModelAdapterSerializer.class) | |||
| protected SaleToAcquirerDataModel saleToAcquirerData; | |||
There was a problem hiding this comment.
We can skip Model in name of class and keep it SaleToAcquirerData because package name already has "model"
There was a problem hiding this comment.
good point I agree
| @@ -75,7 +79,8 @@ | |||
| * The Sale to acquirer data. | |||
| */ | |||
| @XmlElement(name = "SaleToAcquirerData") | |||
| protected String saleToAcquirerData; | |||
There was a problem hiding this comment.
Removing/changing type saleToAcquirerData field means release won't be backward compatible.
There was a problem hiding this comment.
correct I don't see any other way.
|
|
||
| public String toBase64() { | ||
| String json = PRETTY_PRINT_GSON.toJson(this); | ||
| return new String(Base64.encodeBase64(json.getBytes())); |
There was a problem hiding this comment.
json.getBytes may return in null pointer exception.
There was a problem hiding this comment.
I am wondering when this could happen. this is always an object with application info so it should always contain data.
There was a problem hiding this comment.
"this" won't be null but it is possible that conversion to json has some problem and returns in empty json string.
rikterbeek
changed the title
…uirerData in the right format to Adyen.
Description
Tested scenarios
Fixed issue: