Revert removing npm config set when npm publishing
#1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We followed the [documentation](https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#publish-to-npmjs-and-gpr-with-npm) but got an `ENEEDAUTH` error. With the `npm config set` approach we got a 404 instead, which suggests a wrong API key. However, we know the API key was correct, so the other option was having conflicting ways to configure publishing (`NODE_AUTH_TOKEN` and `npm config set` were both present), or a string interpolation issue (there were no spaces inside the braces). This commit implements only a single way to configure the auth token.
|
jillingk
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We followed the documentation but got an
ENEEDAUTHerror.With the
npm config setapproach we got a 404 instead, which suggests a wrong API key. However, we know the API key was correct, so the other option was having conflicting ways to configure publishing (NODE_AUTH_TOKENandnpm config setwere both present), or a string interpolation issue (there were no spaces inside the braces).This commit implements only a single way to configure the auth token.